[MPS] Fix error check for torch.var on scalar#160889
Closed
malfet wants to merge 1 commit intogh/malfet/492/basefrom
Closed
[MPS] Fix error check for torch.var on scalar#160889malfet wants to merge 1 commit intogh/malfet/492/basefrom
malfet wants to merge 1 commit intogh/malfet/492/basefrom
Conversation
Fixes #160738 [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160889
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 83ab0bb with merge base 114813c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
approved these changes
Aug 18, 2025
Contributor
Author
|
@pytorchbot merge -f "Lint + MPS are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 19, 2025
By re-using deterministic algorithm from https://github.com/pytorch/pytorch/blob/bbc7c03e936ab0fce69dfda1fdf4798523a2fbf8/aten/src/ATen/native/cuda/Indexing.cu#L1106-L1113 Fixes #160845 Pull Request resolved: #160926 Approved by: https://github.com/manuelcandales ghstack dependencies: #160850, #160889
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 21, 2025
Which enables them on MPS device - xfail all `test_index_reduce` on MPS, as op is not implemented - xfail all `test_index_copy` on MPS due to the silent correctness problems, see #160993 - Fixed hard crash in `index_fill` and replaced `skipIfMPS` with `expectedFailueMPS` - Created issue for the lack of deterministic algorithms for MPS backend Pull Request resolved: #160994 Approved by: https://github.com/manuelcandales ghstack dependencies: #160850, #160889, #160926
can-gaa-hou
pushed a commit
to can-gaa-hou/pytorch
that referenced
this pull request
Aug 22, 2025
Fixes pytorch#160738 Pull Request resolved: pytorch#160889 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#160850
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Fixes pytorch#160738 Pull Request resolved: pytorch#160889 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#160850
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
By re-using deterministic algorithm from https://github.com/pytorch/pytorch/blob/bbc7c03e936ab0fce69dfda1fdf4798523a2fbf8/aten/src/ATen/native/cuda/Indexing.cu#L1106-L1113 Fixes pytorch#160845 Pull Request resolved: pytorch#160926 Approved by: https://github.com/manuelcandales ghstack dependencies: pytorch#160850, pytorch#160889
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Which enables them on MPS device - xfail all `test_index_reduce` on MPS, as op is not implemented - xfail all `test_index_copy` on MPS due to the silent correctness problems, see pytorch#160993 - Fixed hard crash in `index_fill` and replaced `skipIfMPS` with `expectedFailueMPS` - Created issue for the lack of deterministic algorithms for MPS backend Pull Request resolved: pytorch#160994 Approved by: https://github.com/manuelcandales ghstack dependencies: pytorch#160850, pytorch#160889, pytorch#160926
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #160738