[FSDP][Replicate] tests that parameter sharing works in replicated modules#160464
Closed
anshul-si wants to merge 4 commits intogh/anshul-si/24/basefrom
Closed
[FSDP][Replicate] tests that parameter sharing works in replicated modules#160464anshul-si wants to merge 4 commits intogh/anshul-si/24/basefrom
anshul-si wants to merge 4 commits intogh/anshul-si/24/basefrom
Conversation
…dules [ghstack-poisoned]
This was referenced Aug 12, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160464
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a59e542 with merge base e6aa728 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 12, 2025
…plicated modules" [ghstack-poisoned]
mori360
approved these changes
Aug 12, 2025
…plicated modules" **Summary:** In order to ensure that replicate acts as intended (a specialized version of hsdp) we need to make sure that it can pass the same tests that fully_shard can for training. This tests that `replicate` function properly handles models with shared parameters **Test Cases** 1. pytest test/distributed/_composable/test_replicate_training.py -k test_train_parity_with_shared_params [ghstack-poisoned]
This was referenced Aug 13, 2025
anshul-si
added a commit
to anshul-si/pytorch
that referenced
this pull request
Aug 21, 2025
…dules ghstack-source-id: 19e3d1e Pull Request resolved: pytorch#160464
anshul-si
added a commit
to anshul-si/pytorch
that referenced
this pull request
Aug 26, 2025
…dules ghstack-source-id: 19e3d1e Pull Request resolved: pytorch#160464
anshul-si
added a commit
to anshul-si/pytorch
that referenced
this pull request
Aug 26, 2025
…dules ghstack-source-id: 19e3d1e Pull Request resolved: pytorch#160464
…plicated modules" **Summary:** In order to ensure that replicate acts as intended (a specialized version of hsdp) we need to make sure that it can pass the same tests that fully_shard can for training. This tests that `replicate` function properly handles models with shared parameters **Test Cases** 1. pytest test/distributed/_composable/test_replicate_training.py -k test_train_parity_with_shared_params [ghstack-poisoned]
anshul-si
added a commit
to anshul-si/pytorch
that referenced
this pull request
Sep 2, 2025
…dules ghstack-source-id: 19e3d1e Pull Request resolved: pytorch#160464
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: In order to ensure that replicate acts as intended (a specialized version of hsdp) we need to make sure that it can pass the same tests that fully_shard can for training. This tests that
replicatefunction properly handles models with shared parametersTest Cases
Stack from ghstack (oldest at bottom):