[FSDP][Replicate] added test cases to ensure replicate can run forward/backward through root and non root and when a module is used multiple times in a single forward pass#160441
Closed
anshul-si wants to merge 3 commits intogh/anshul-si/21/basefrom
Conversation
…d/backward through root and non root and when a module is used multiple times in a single forward pass [ghstack-poisoned]
This was referenced Aug 12, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160441
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 022cb4a with merge base e6aa728 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 12, 2025
This was referenced Aug 12, 2025
… run forward/backward through root and non root and when a module is used multiple times in a single forward pass" **Summary:** In order to ensure that replicate acts as intended (a specialized version of hsdp) we need to make sure that it can pass the same tests that fully_shard can for training. The first test verifies that Replicate correctly handles the scenario where forward and backward passes are run through both the root module and a non-root module. The second test verifies that Replicate works correctly when a module is used multiple times in a single forward pass. **Test Cases** 1. pytest test/distributed/_composable/test_replicate_training.py -k test_non_root_forward_backward 2. pytest test/distributed/_composable/test_replicate_training.py -k test_multi_forward_module cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
This was referenced Aug 13, 2025
anshul-si
added a commit
to anshul-si/pytorch
that referenced
this pull request
Aug 21, 2025
…d/backward through root and non root and when a module is used multiple times in a single forward pass ghstack-source-id: 3019f4d Pull Request resolved: pytorch#160441
anshul-si
added a commit
to anshul-si/pytorch
that referenced
this pull request
Aug 26, 2025
…d/backward through root and non root and when a module is used multiple times in a single forward pass ghstack-source-id: 3019f4d Pull Request resolved: pytorch#160441
anshul-si
added a commit
to anshul-si/pytorch
that referenced
this pull request
Aug 26, 2025
…d/backward through root and non root and when a module is used multiple times in a single forward pass ghstack-source-id: 3019f4d Pull Request resolved: pytorch#160441
… run forward/backward through root and non root and when a module is used multiple times in a single forward pass" **Summary:** In order to ensure that replicate acts as intended (a specialized version of hsdp) we need to make sure that it can pass the same tests that fully_shard can for training. The first test verifies that Replicate correctly handles the scenario where forward and backward passes are run through both the root module and a non-root module. The second test verifies that Replicate works correctly when a module is used multiple times in a single forward pass. **Test Cases** 1. pytest test/distributed/_composable/test_replicate_training.py -k test_non_root_forward_backward 2. pytest test/distributed/_composable/test_replicate_training.py -k test_multi_forward_module cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
anshul-si
added a commit
to anshul-si/pytorch
that referenced
this pull request
Sep 2, 2025
…d/backward through root and non root and when a module is used multiple times in a single forward pass ghstack-source-id: 3019f4d Pull Request resolved: pytorch#160441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: In order to ensure that replicate acts as intended (a specialized version of hsdp) we need to make sure that it can pass the same tests that fully_shard can for training. The first test verifies that Replicate correctly handles the scenario where forward and backward passes are run through both the root module and a non-root module. The second test verifies that Replicate works correctly when a module is used multiple times in a single forward pass.
Test Cases
Stack from ghstack (oldest at bottom):
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta