[Inductor UT][Fix XPU CI] Fix case failures introduced by community. by etaf · Pull Request #159759 · pytorch/pytorch

etaf · 2025-08-04T07:53:09Z

Stack from ghstack (oldest at bottom):

[Linter] Expanding the scope of detecting device-bias code. #159949
[Linter] Improve device-bias linter by adding detection for with torch.device("cuda"). #159926
-> [Inductor UT][Fix XPU CI] Fix case failures introduced by community. #159759

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela

[ghstack-poisoned]

pytorch-bot · 2025-08-04T07:53:12Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159759

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

ghstack-mergeability-check and Check labels failing with 'Resource not accessible by integration'

✅ You can merge normally! (1 Unrelated Failure)

As of commit 1e598db with merge base c03a734 ():

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable) (gh) (#158876)
/var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 5394827 Pull Request resolved: #159759

… by community." cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]

ghstack-source-id: c07ac17 Pull Request resolved: #159759

EikanWang · 2025-08-04T22:49:25Z

@etaf , regarding the two failures, we need to update the torch-xpu-ops. So, it would be helpful to stack the torch-xpu-ops upgrade pr to make the CI signal of this PR green.

etaf · 2025-08-05T02:12:32Z

@etaf , regarding the two failures, we need to update the torch-xpu-ops. So, it would be helpful to stack the torch-xpu-ops upgrade pr to make the CI signal of this PR green.

The above two windows build failures will be fixed in pytorch xpu windows build script by #159763, not related to torch-xpu-ops.

guangyey · 2025-08-05T03:51:00Z

test/test_dataloader.py

            self.assertTrue(sample["a_tensor"].is_pinned())
            self.assertTrue(sample["another_dict"]["a_number"].is_pinned())

+    @skipIfXpu


This fix is already landed in #159811

jansel

Test failures look related?

etaf · 2025-08-05T05:37:33Z

Test failures look related?

Hi, @jansel: The above two windows build failures are not related to this PR and will be fixed in pytorch xpu windows build script by #159763.

…community." Fixes #159631 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]

ghstack-source-id: c102582 Pull Request resolved: #159759

…community." Fixes #159631 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]

ghstack-source-id: da48eca Pull Request resolved: #159759

…community." Fixes #159631 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela [ghstack-poisoned]

ghstack-source-id: 08a9147 Pull Request resolved: #159759

jansel · 2025-08-06T04:40:45Z

You should rebase this PR past the fix, we shouldn't break trunk.

etaf · 2025-08-06T05:21:24Z

You should rebase this PR past the fix, we shouldn't break trunk.

Oh I know what you mean, thanks for the reminder.

…community." Fixes #159631 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela [ghstack-poisoned]

etaf · 2025-08-06T19:59:57Z

@pytorchbot merge

pytorchmergebot · 2025-08-06T20:01:56Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…ch.device("cuda")`. (#159926) ``` For example, detect the following situation: >>>Lint for test/dynamo/test_modes.py: Error (TEST_DEVICE_BIAS) [device-bias] `@requires_gpu` function should not hardcode `with torch.device('cuda')`, suggest to use torch.device(GPU_TYPE) 687 | flex_attention as flex_attention_eager, 688 | ) 689 | >>> 690 | with torch.device("cuda"): 691 | flex_attention = torch.compile(flex_attention_eager, dynamic=False) 692 | 693 | with self.assertRaisesRegex( ``` Pull Request resolved: #159926 Approved by: https://github.com/EikanWang, https://github.com/jansel ghstack dependencies: #159759

…ch.device("cuda")`. (pytorch#159926) ``` For example, detect the following situation: >>>Lint for test/dynamo/test_modes.py: Error (TEST_DEVICE_BIAS) [device-bias] `@requires_gpu` function should not hardcode `with torch.device('cuda')`, suggest to use torch.device(GPU_TYPE) 687 | flex_attention as flex_attention_eager, 688 | ) 689 | >>> 690 | with torch.device("cuda"): 691 | flex_attention = torch.compile(flex_attention_eager, dynamic=False) 692 | 693 | with self.assertRaisesRegex( ``` Pull Request resolved: pytorch#159926 Approved by: https://github.com/EikanWang, https://github.com/jansel ghstack dependencies: pytorch#159759

…ytorch#159759) Fixes pytorch#159631 Pull Request resolved: pytorch#159759 Approved by: https://github.com/EikanWang, https://github.com/jansel

…ch.device("cuda")`. (pytorch#159926) ``` For example, detect the following situation: >>>Lint for test/dynamo/test_modes.py: Error (TEST_DEVICE_BIAS) [device-bias] `@requires_gpu` function should not hardcode `with torch.device('cuda')`, suggest to use torch.device(GPU_TYPE) 687 | flex_attention as flex_attention_eager, 688 | ) 689 | >>> 690 | with torch.device("cuda"): 691 | flex_attention = torch.compile(flex_attention_eager, dynamic=False) 692 | 693 | with self.assertRaisesRegex( ``` Pull Request resolved: pytorch#159926 Approved by: https://github.com/EikanWang, https://github.com/jansel ghstack dependencies: pytorch#159759

[Fix XPU][Inductor UT] Fix XPU CI case failures introduced by community.

ce6f580

[ghstack-poisoned]

etaf added a commit that referenced this pull request Aug 4, 2025

[Fix XPU][Inductor UT] Fix XPU CI case failures introduced by community.

7645585

ghstack-source-id: 5394827 Pull Request resolved: #159759

pytorch-bot bot added ciflow/inductor module: inductor topic: not user facing topic category labels Aug 4, 2025

etaf added the ciflow/xpu Run XPU CI tasks label Aug 4, 2025

pytorchbot added the open source label Aug 4, 2025

etaf added a commit that referenced this pull request Aug 4, 2025

[Fix XPU][Inductor UT] Fix XPU CI case failures introduced by community.

68637fa

ghstack-source-id: c07ac17 Pull Request resolved: #159759

etaf changed the title ~~[Fix XPU][Inductor UT] Fix XPU CI case failures introduced by community.~~ [Inductor UT] Fix XPU CI case failures introduced by community. Aug 4, 2025

etaf changed the title ~~[Inductor UT] Fix XPU CI case failures introduced by community.~~ [Inductor UT][XPU] Fix XPU CI case failures introduced by community. Aug 4, 2025

etaf requested a review from jansel August 4, 2025 16:05

EikanWang approved these changes Aug 4, 2025

View reviewed changes

etaf added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 5, 2025

etaf changed the title ~~[Inductor UT][XPU] Fix XPU CI case failures introduced by community.~~ [Inductor UT][Fix XPU CI] Fix case failures introduced by community. Aug 5, 2025

etaf requested a review from albanD August 5, 2025 02:32

guangyey reviewed Aug 5, 2025

View reviewed changes

guangyey mentioned this pull request Aug 5, 2025

DISABLED test_repeat_interleave_2_dynamic_shapes_xpu (__main__.DynamicShapesCodegenGPUTests) #159803

Closed

jansel requested changes Aug 5, 2025

View reviewed changes

etaf added a commit that referenced this pull request Aug 5, 2025

[Fix XPU][Inductor UT] Fix XPU CI case failures introduced by community.

462060a

ghstack-source-id: c102582 Pull Request resolved: #159759

etaf requested a review from jansel August 5, 2025 08:06

albanD removed their request for review August 5, 2025 18:28

etaf added a commit that referenced this pull request Aug 6, 2025

[Fix XPU][Inductor UT] Fix XPU CI case failures introduced by community.

ad39cc1

ghstack-source-id: da48eca Pull Request resolved: #159759

pytorch-bot bot added the module: dynamo label Aug 6, 2025

etaf added a commit that referenced this pull request Aug 6, 2025

[Fix XPU][Inductor UT] Fix XPU CI case failures introduced by community.

2d66f79

ghstack-source-id: 08a9147 Pull Request resolved: #159759

etaf mentioned this pull request Aug 6, 2025

[Linter] Improve device-bias linter by adding detection for with torch.device("cuda"). #159926

Closed

etaf mentioned this pull request Aug 6, 2025

[Linter] Expanding the scope of detecting device-bias code. #159949

Closed

jansel approved these changes Aug 6, 2025

View reviewed changes

pytorchmergebot added the merging label Aug 6, 2025

pytorchmergebot added the Merged label Aug 6, 2025

pytorchmergebot closed this in 12a54e4 Aug 6, 2025

pytorchmergebot removed the merging label Aug 6, 2025

This was referenced Aug 7, 2025

DISABLED test_hop (__main__.TorchFunctionModeTests) #159951

Closed

DISABLED test_hop_eager (__main__.TorchFunctionModeTests) #159950

Closed

DISABLED test_comment_graph_fragment (__main__.TritonCodeGenTests) #159925

Closed

github-actions bot deleted the gh/etaf/150/head branch September 6, 2025 02:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Inductor UT][Fix XPU CI] Fix case failures introduced by community.#159759

[Inductor UT][Fix XPU CI] Fix case failures introduced by community.#159759
etaf wants to merge 7 commits intogh/etaf/150/basefrom
gh/etaf/150/head

etaf commented Aug 4, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

EikanWang commented Aug 4, 2025

Uh oh!

etaf commented Aug 5, 2025

Uh oh!

guangyey Aug 5, 2025

Uh oh!

jansel left a comment

Uh oh!

etaf commented Aug 5, 2025

Uh oh!

jansel commented Aug 6, 2025

Uh oh!

etaf commented Aug 6, 2025

Uh oh!

etaf commented Aug 6, 2025

Uh oh!

pytorchmergebot commented Aug 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

etaf commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159759

❗ 1 Active SEVs

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

EikanWang commented Aug 4, 2025

Uh oh!

etaf commented Aug 5, 2025

Uh oh!

guangyey Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

jansel left a comment

Choose a reason for hiding this comment

Uh oh!

etaf commented Aug 5, 2025

Uh oh!

jansel commented Aug 6, 2025

Uh oh!

etaf commented Aug 6, 2025

Uh oh!

etaf commented Aug 6, 2025

Uh oh!

pytorchmergebot commented Aug 6, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

etaf commented Aug 4, 2025 •

edited

Loading

pytorch-bot bot commented Aug 4, 2025 •

edited

Loading