Skip to content

[Linter] Expanding the scope of detecting device-bias code.#159949

Closed
etaf wants to merge 5 commits intogh/etaf/152/basefrom
gh/etaf/152/head
Closed

[Linter] Expanding the scope of detecting device-bias code.#159949
etaf wants to merge 5 commits intogh/etaf/152/basefrom
gh/etaf/152/head

Conversation

@etaf
Copy link
Collaborator

@etaf etaf commented Aug 6, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Currently, the device-bias linter only targets functions decorated with @requires_gpu. This PR adds support for two new detection scenarios:

  1. Detect device-bias code in functions decorated with @requires_triton.
  2. Detect device-bias code for entire test suites that are defined as shared across GPUs. For example:
if __name__ == "__main__":
    if HAS_GPU:
        run_tests()

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela

@etaf
[Linter] Expanding the scope of detecting device-bias code.
1ba38f9 
Currently, the device-bias linter only targets functions decorated with @requires_gpu. This PR adds support for two new detection scenarios:
1. Detect device-bias code in functions decorated with @requires_triton.
2. Detect device-bias code for entire test suites that are defined as shared across GPUs.

[ghstack-poisoned]
This was referenced Aug 6, 2025
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159949

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c989db5 with merge base 24257f5 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

etaf added a commit that referenced this pull request Aug 6, 2025
@etaf
[Linter] Expanding the scope of detecting device-bias code.
c13968f 
Currently, the device-bias linter only targets functions decorated with requires_gpu. This PR adds support for two new detection scenarios:
1. Detect device-bias code in functions decorated with requires_triton.
2. Detect device-bias code for entire test suites that are defined as shared across GPUs.

ghstack-source-id: c281a61
Pull Request resolved: #159949
@etaf
Update on "[Linter] Expanding the scope of detecting device-bias code."
526ca50 
Currently, the device-bias linter only targets functions decorated with requires_gpu. This PR adds support for two new detection scenarios:
1. Detect device-bias code in functions decorated with requires_triton.
2. Detect device-bias code for entire test suites that are defined as shared across GPUs. For example:
```
if __name__ == "__main__":
    if HAS_GPU:
        run_tests()

```


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
etaf added a commit that referenced this pull request Aug 6, 2025
@etaf
[Linter] Expanding the scope of detecting device-bias code.
05d3a14 
Currently, the device-bias linter only targets functions decorated with requires_gpu. This PR adds support for two new detection scenarios:
1. Detect device-bias code in functions decorated with requires_triton.
2. Detect device-bias code for entire test suites that are defined as shared across GPUs.

ghstack-source-id: 1c861e7
Pull Request resolved: #159949
@etaf
Update on "[Linter] Expanding the scope of detecting device-bias code."
bd24343 
Currently, the device-bias linter only targets functions decorated with requires_gpu. This PR adds support for two new detection scenarios:
1. Detect device-bias code in functions decorated with requires_triton.
2. Detect device-bias code for entire test suites that are defined as shared across GPUs. For example:
```
if __name__ == "__main__":
    if HAS_GPU:
        run_tests()

```


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
etaf added a commit that referenced this pull request Aug 6, 2025
@etaf
[Linter] Expanding the scope of detecting device-bias code.
d4b7393 
Currently, the device-bias linter only targets functions decorated with requires_gpu. This PR adds support for two new detection scenarios:
1. Detect device-bias code in functions decorated with requires_triton.
2. Detect device-bias code for entire test suites that are defined as shared across GPUs.

ghstack-source-id: 46fbe22
Pull Request resolved: #159949
@etaf etaf requested a review from malfet August 6, 2025 11:09
@etaf
Update on "[Linter] Expanding the scope of detecting device-bias code."
cf6fb69 
Currently, the device-bias linter only targets functions decorated with requires_gpu. This PR adds support for two new detection scenarios:
1. Detect device-bias code in functions decorated with requires_triton.
2. Detect device-bias code for entire test suites that are defined as shared across GPUs. For example:
```
if __name__ == "__main__":
    if HAS_GPU:
        run_tests()

```


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
etaf added a commit that referenced this pull request Aug 6, 2025
@etaf
[Linter] Expanding the scope of detecting device-bias code.
b38bdd0 
Currently, the device-bias linter only targets functions decorated with requires_gpu. This PR adds support for two new detection scenarios:
1. Detect device-bias code in functions decorated with requires_triton.
2. Detect device-bias code for entire test suites that are defined as shared across GPUs.

ghstack-source-id: e342ab2
Pull Request resolved: #159949
@etaf etaf requested a review from jansel August 6, 2025 19:59
@etaf
Copy link
Collaborator Author

etaf commented Aug 8, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 8, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 8, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 8, 2025

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x b38bdd0d256cd155506bc61641cfcd056f48fe46 returned non-zero exit code 1

Auto-merging test/inductor/test_aot_inductor.py
Auto-merging test/inductor/test_max_autotune.py
Auto-merging tools/linter/adapters/test_device_bias_linter.py
CONFLICT (content): Merge conflict in tools/linter/adapters/test_device_bias_linter.py
error: could not apply b38bdd0d256... [Linter] Expanding the scope of detecting device-bias code.
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@etaf
Update on "[Linter] Expanding the scope of detecting device-bias code."
c989db5 
Currently, the device-bias linter only targets functions decorated with requires_gpu. This PR adds support for two new detection scenarios:
1. Detect device-bias code in functions decorated with requires_triton.
2. Detect device-bias code for entire test suites that are defined as shared across GPUs. For example:
```
if __name__ == "__main__":
    if HAS_GPU:
        run_tests()

```


cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
etaf added a commit that referenced this pull request Aug 8, 2025
@etaf
[Linter] Expanding the scope of detecting device-bias code.
c7b9b1d 
Currently, the device-bias linter only targets functions decorated with requires_gpu. This PR adds support for two new detection scenarios:
1. Detect device-bias code in functions decorated with requires_triton.
2. Detect device-bias code for entire test suites that are defined as shared across GPUs.

ghstack-source-id: 0afd6a8
Pull Request resolved: #159949
@etaf
Copy link
Collaborator Author

etaf commented Aug 9, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 9, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/etaf/152/head branch September 9, 2025 02:09
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@etaf @markc-614
[Linter] Expanding the scope of detecting device-bias code. (pytorch#…
f853948 
…159949)

Currently, the device-bias linter only targets functions decorated with @requires_gpu. This PR adds support for two new detection scenarios:
1. Detect device-bias code in functions decorated with @requires_triton.
2. Detect device-bias code for entire test suites that are defined as shared across GPUs. For example:
```
if __name__ == "__main__":
    if HAS_GPU:
        run_tests()

```

Pull Request resolved: pytorch#159949
Approved by: https://github.com/EikanWang, https://github.com/jansel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@EikanWang EikanWang EikanWang approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@etaf @pytorchmergebot @jansel @EikanWang @pytorchbot