Patch the _is_conv_node function by cccclai · Pull Request #153749 · pytorch/pytorch

cccclai · 2025-05-16T19:00:21Z

Summary: torch.ops.aten.conv2d.padding is also conv2d node

Differential Revision: D74898941

pytorch-bot · 2025-05-16T19:00:25Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153749

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 47 Pending

As of commit 725c2f6 with merge base 4277907 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-05-16T19:00:37Z

This pull request was exported from Phabricator. Differential Revision: D74898941

Skylion007 · 2025-05-19T16:44:55Z

Suggested change

torch.ops.aten.conv1d.default,

torch.ops.aten.conv2d.default,

torch.ops.aten.conv2d.padding,

torch.ops.aten.conv1d.default,

torch.ops.aten.conv1d.padding,

torch.ops.aten.conv2d.default,

torch.ops.aten.conv2d.padding,

What about conv3d?

Suggested change

torch.ops.aten.conv1d.default,

torch.ops.aten.conv2d.default,

torch.ops.aten.conv2d.padding,

torch.ops.aten.conv1d.default,

torch.ops.aten.conv1d.padding,

torch.ops.aten.conv2d.default,

torch.ops.aten.conv2d.padding,

torch.ops.aten.conv3d.default,

torch.ops.aten.conv3d.padding,

I added conv3d in torchao/quantization/pt2e,

@cccclai might be good to abandon these changes

Wait so this func is unused now?

Our partner is still using pytorch but not torch ao currently, I think it's an easy fix?

@cccclai Might as well be complete and ad all the conv types then.

Skylion007 · 2025-05-19T16:52:26Z

Do we need to add any tests for the quantization ops?

Summary: X-link: pytorch/pytorch#153749 torch.ops.aten.conv2d.padding is also conv2d node Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941

Skylion007

LGTM if you also fix the utility here

Summary: X-link: pytorch/ao#2223 torch.ops.aten.conv2d.padding is also conv2d node Test Plan: CI Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941

facebook-github-bot · 2025-05-20T05:55:12Z

This pull request was exported from Phabricator. Differential Revision: D74898941

cccclai · 2025-05-20T05:58:34Z

LGTM if you also fix the utility here

Does it look good now?

Skylion007 · 2025-05-20T13:55:41Z

@cccclai Yeah, just fix the trailing spaces in the lint

Summary: Pull Request resolved: pytorch#2223 X-link: pytorch/pytorch#153749 torch.ops.aten.conv2d.padding is also conv2d node Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941

Summary: X-link: pytorch/pytorch#153749 torch.ops.aten.conv2d.padding is also conv2d node Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941

facebook-github-bot · 2025-05-22T18:13:31Z

This pull request was exported from Phabricator. Differential Revision: D74898941

cccclai · 2025-05-22T18:14:39Z

I added the test in pytorch/ao#2223. The same test doesn't work in pytorch, looks like the quant nodes disappear.

Summary: X-link: pytorch/pytorch#153749 torch.ops.aten.conv2d.padding is also conv2d node Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941

Summary: X-link: pytorch/ao#2223 torch.ops.aten.conv2d.padding is also conv2d node Test Plan: CI Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941

facebook-github-bot · 2025-05-22T18:59:59Z

This pull request was exported from Phabricator. Differential Revision: D74898941

facebook-github-bot · 2025-05-22T22:08:58Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2025-05-22T22:11:22Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

facebook-github-bot · 2025-05-23T19:02:04Z

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

pytorchmergebot · 2025-05-23T19:04:12Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit c985cec. Reverted #153749 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#153749 (comment)))

pytorchmergebot · 2025-05-23T19:04:24Z

@cccclai your PR has been successfully reverted.

cccclai · 2025-05-23T21:02:35Z

Close as the PR is reverted

cccclai · 2025-05-28T01:17:22Z

Reland the pr in #154473 and pytorch/ao#2257

pytorch-bot Bot added release notes: quantization release notes category release notes: AO frontend labels May 16, 2025

facebook-github-bot added the fb-exported label May 16, 2025

cccclai requested review from andrewor14 and jerryzh168 May 16, 2025 19:03

andrewor14 approved these changes May 19, 2025

View reviewed changes

pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 19, 2025

Skylion007 reviewed May 19, 2025

View reviewed changes

cccclai added a commit to cccclai/ao that referenced this pull request May 19, 2025

Patch the _is_conv_node function

85d6e55

Summary: X-link: pytorch/pytorch#153749 torch.ops.aten.conv2d.padding is also conv2d node Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941

cccclai mentioned this pull request May 19, 2025

Patch the _is_conv_node function pytorch/ao#2223

Merged

Skylion007 approved these changes May 19, 2025

View reviewed changes

cccclai force-pushed the export-D74898941 branch from 110aee3 to 7a144ea Compare May 20, 2025 05:54

Skylion007 approved these changes May 20, 2025

View reviewed changes

cccclai force-pushed the export-D74898941 branch from 7a144ea to f7a791e Compare May 22, 2025 18:13

Patch the _is_conv_node function (pytorch#153749)

725c2f6

Summary: X-link: pytorch/ao#2223 torch.ops.aten.conv2d.padding is also conv2d node Test Plan: CI Reviewed By: andrewor14, jerryzh168 Differential Revision: D74898941

cccclai force-pushed the export-D74898941 branch from f7a791e to 725c2f6 Compare May 22, 2025 18:59

pytorchmergebot added the merging label May 22, 2025

pytorchmergebot closed this in c985cec May 22, 2025

pytorchmergebot added Merged and removed merging labels May 22, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels May 23, 2025

pytorchmergebot reopened this May 23, 2025

cccclai closed this May 23, 2025

-        torch.ops.aten.conv1d.default,
-        torch.ops.aten.conv2d.default,
-        torch.ops.aten.conv2d.padding,
+        torch.ops.aten.conv1d.default,
+        torch.ops.aten.conv1d.padding,
+        torch.ops.aten.conv2d.default,
+        torch.ops.aten.conv2d.padding,

Conversation

cccclai commented May 16, 2025

Uh oh!

pytorch-bot Bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153749

⏳ No Failures, 47 Pending

Uh oh!

facebook-github-bot commented May 16, 2025

Uh oh!

Skylion007 May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jerryzh168 May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Skylion007 May 19, 2025

Choose a reason for hiding this comment

Uh oh!

cccclai May 19, 2025

Choose a reason for hiding this comment

Uh oh!

Skylion007 May 19, 2025

Choose a reason for hiding this comment

Uh oh!

Skylion007 commented May 19, 2025

Uh oh!

Skylion007 left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented May 20, 2025

Uh oh!

cccclai commented May 20, 2025

Uh oh!

Skylion007 commented May 20, 2025

Uh oh!

facebook-github-bot commented May 22, 2025

Uh oh!

cccclai commented May 22, 2025

Uh oh!

facebook-github-bot commented May 22, 2025

Uh oh!

facebook-github-bot commented May 22, 2025

Uh oh!

pytorchmergebot commented May 22, 2025

Merge started

Uh oh!

facebook-github-bot commented May 23, 2025

Uh oh!

pytorchmergebot commented May 23, 2025

Uh oh!

pytorchmergebot commented May 23, 2025

Uh oh!

cccclai commented May 23, 2025

Uh oh!

cccclai commented May 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pytorch-bot Bot commented May 16, 2025 •

edited

Loading

Skylion007 May 19, 2025 •

edited

Loading

jerryzh168 May 19, 2025 •

edited

Loading