Skip to content

[Reland][pytorch] Patch the _is_conv_node function#154473

Closed
cccclai wants to merge 1 commit into
pytorch:mainfrom
cccclai:export-D75494468
Closed

[Reland][pytorch] Patch the _is_conv_node function#154473
cccclai wants to merge 1 commit into
pytorch:mainfrom
cccclai:export-D75494468

Conversation

@cccclai

@cccclai cccclai commented May 28, 2025

Copy link
Copy Markdown
Contributor

Summary: Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:

buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'

Differential Revision: D75494468

@cccclai cccclai requested a review from jerryzh168 as a code owner May 28, 2025 01:16
@pytorch-bot

pytorch-bot Bot commented May 28, 2025 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154473

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e71e444 with merge base 83a0e4e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added ci-no-td Do not run TD on this PR release notes: quantization release notes category labels May 28, 2025
@facebook-github-bot

facebook-github-bot commented May 28, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D75494468

@cccclai cccclai mentioned this pull request May 28, 2025
Closed
@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 28, 2025
@cccclai cccclai force-pushed the export-D75494468 branch from cddf2ca to e8ebd48 Compare May 28, 2025 21:45
@facebook-github-bot

facebook-github-bot commented May 28, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D75494468

@cccclai cccclai force-pushed the export-D75494468 branch from e8ebd48 to 257cf94 Compare May 28, 2025 21:46
@cccclai cccclai force-pushed the export-D75494468 branch from 257cf94 to 20fdebb Compare May 28, 2025 21:47
@facebook-github-bot

facebook-github-bot commented May 28, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D75494468

@cccclai cccclai force-pushed the export-D75494468 branch from 20fdebb to e80a210 Compare May 28, 2025 21:50
@facebook-github-bot

facebook-github-bot commented May 28, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D75494468

@cccclai cccclai force-pushed the export-D75494468 branch from e80a210 to 2730754 Compare May 28, 2025 21:56
cccclai added a commit to cccclai/pytorch that referenced this pull request May 28, 2025
@cccclai @facebook-github-bot
[Reland][pytorch] Patch the _is_conv_node function (pytorch#154473)
2730754 
Summary:
Pull Request resolved: pytorch#154473

Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468
@cccclai

cccclai commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorchmergebot

pytorchmergebot commented May 28, 2025

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot

pytorchmergebot commented May 28, 2025

Copy link
Copy Markdown
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@cccclai @facebook-github-bot
[Reland][pytorch] Patch the _is_conv_node function (pytorch#154473)
e71e444 
Summary:

Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468
@cccclai cccclai force-pushed the export-D75494468 branch from 2730754 to e71e444 Compare May 29, 2025 21:01
@facebook-github-bot

facebook-github-bot commented May 29, 2025

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D75494468

@cccclai

cccclai commented May 29, 2025

Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorchmergebot

pytorchmergebot commented May 29, 2025

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull request Jun 4, 2025
@cccclai @iupaikov-amd
[Reland][pytorch] Patch the _is_conv_node function (pytorch#154473)
7d5ab57 
Summary: Add the conv padding ops in pytorch, the corresponding pr in torch ao is pytorch/ao#2257

Test Plan:
```
buck test 'fbcode//mode/opt' fbcode//caffe2/test:quantization_pt2e -- --exact 'caffe2/test:quantization_pt2e - test_conv_padding_bn_relu (quantization.pt2e.test_quantize_pt2e.TestQuantizePT2E)'
```

Differential Revision: D75494468

Pull Request resolved: pytorch#154473
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cccclai @facebook-github-bot @pytorchmergebot @Skylion007