[ROCm][TunableOp] Fix TunableOp BLAS logging for online tuning case.#148979
Closed
naromero77amd wants to merge 1 commit intopytorch:mainfrom
Closed
[ROCm][TunableOp] Fix TunableOp BLAS logging for online tuning case.#148979naromero77amd wants to merge 1 commit intopytorch:mainfrom
naromero77amd wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148979
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit c4bc4c7 with merge base 492f3fd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jeffdaily
approved these changes
Mar 11, 2025
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 19, 2025
Add unit test for new TunableOp BLAS logging feature. Requires this PR to be merged in first: #148979 Pull Request resolved: #148982 Approved by: https://github.com/jeffdaily
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
Add unit test for new TunableOp BLAS logging feature. Requires this PR to be merged in first: pytorch#148979 Pull Request resolved: pytorch#148982 Approved by: https://github.com/jeffdaily
naromero77amd
added a commit
to ROCm/pytorch
that referenced
this pull request
May 8, 2025
Add unit test for new TunableOp BLAS logging feature. Requires this PR to be merged in first: pytorch#148979 Pull Request resolved: pytorch#148982 Approved by: https://github.com/jeffdaily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a previous PR #147034, there was a bad merge at the last minute.
BLAS logging works for offline tuning, but does not currently work for online tuning.
This PR fixes BLAS logging for online tuning.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang