[ROCm] [TunableOp] Enable logging of BLAS parameters#147034
Closed
naromero77amd wants to merge 23 commits intopytorch:mainfrom
Closed
[ROCm] [TunableOp] Enable logging of BLAS parameters#147034naromero77amd wants to merge 23 commits intopytorch:mainfrom
naromero77amd wants to merge 23 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147034
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 7d01188 with merge base 703176e ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jeffdaily
reviewed
Feb 20, 2025
| return "Unknown ComputeType"; | ||
| } | ||
|
|
||
| #ifdef USE_ROCM |
Collaborator
There was a problem hiding this comment.
Why is ComputeTypeFor inside the #ifdef USE_ROCM?
93db444 to
8655414
Compare
jeffdaily
approved these changes
Mar 6, 2025
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 11, 2025
…148979) In a previous PR #147034, there was a bad merge at the last minute. BLAS logging works for offline tuning, but does not currently work for online tuning. This PR fixes BLAS logging for online tuning. Pull Request resolved: #148979 Approved by: https://github.com/jeffdaily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports a logging feature that is being requested.
Enables the logging of BLAS parameters with either offline or online (in-situ) tuning.
The BLAS parameters are written to the CSV file.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang