[EZ][BE] Increase tolerances for interpolate op#148224
Closed
malfet wants to merge 1 commit intogh/malfet/203/basefrom
Closed
[EZ][BE] Increase tolerances for interpolate op#148224malfet wants to merge 1 commit intogh/malfet/203/basefrom
malfet wants to merge 1 commit intogh/malfet/203/basefrom
Conversation
Not sure why there were set like that, they were added in #104181 without much explanation, but I guess it was due to the low tolerance of bilinear op [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148224
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ab81ccc with merge base 926b7b5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
approved these changes
Mar 1, 2025
dcci
approved these changes
Mar 1, 2025
Contributor
Author
|
@pytorchbot merge -f "Why more tests are good?" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
upsample_kernel_out_templateinto one #148211Not sure why tolerances were set like that, this logic was added in #104181 without much explanation
But if I'm to make a guess, it's likely due to the inaccuracy of bilinear op, that has since been replaced by shader