Skip to content

Added new test sample to interpolate op in OpInfo#104181

Closed
vfdev-5 wants to merge 11 commits intogh/vfdev-5/10/basefrom
gh/vfdev-5/10/head
Closed

Added new test sample to interpolate op in OpInfo#104181
vfdev-5 wants to merge 11 commits intogh/vfdev-5/10/basefrom
gh/vfdev-5/10/head

Conversation

@vfdev-5
Copy link
Copy Markdown
Contributor

@vfdev-5 vfdev-5 commented Jun 26, 2023 •
edited by pytorchmergebot
Loading

@vfdev-5 vfdev-5 requested review from mruberry and ngimel as code owners June 26, 2023 08:55
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jun 26, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104181

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit ae53a40 with merge base 371d8ba (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vfdev-5 vfdev-5 mentioned this pull request Jun 26, 2023
Closed
@vfdev-5 vfdev-5 requested a review from pmeier June 26, 2023 08:56
@vfdev-5 vfdev-5 mentioned this pull request Jun 27, 2023
Closed
pmeier
pmeier previously requested changes Jun 27, 2023
View reviewed changes
pmeier
pmeier reviewed Jun 27, 2023
View reviewed changes
@pmeier pmeier dismissed their stale review June 27, 2023 15:24

Change to make_tensor was reverted

@vfdev-5 vfdev-5 requested review from peterbell10 and pmeier June 29, 2023 08:37
pmeier
pmeier approved these changes Jun 29, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning the sample inputs method Victor!

@vfdev-5
Copy link
Copy Markdown
Contributor Author

vfdev-5 commented Jul 3, 2023

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 3, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 3, 2023

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 3, 2023

Successfully rebased gh/vfdev-5/10/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/104181)

pytorchmergebot pushed a commit that referenced this pull request Jul 3, 2023
@vfdev-5
Added new test sample to interpolate op in OpInfo
cc0a7ac 
Description:
- Added new test sample to interpolate op in OpInfo
- Fixed silent issue with zero tensor test sample for uint8 dtype

ghstack-source-id: ea9d3da
Pull Request resolved: #104181
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 3, 2023

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@vfdev-5 vfdev-5 added the topic: not user facing topic category label Jul 3, 2023
@vfdev-5
Copy link
Copy Markdown
Contributor Author

vfdev-5 commented Jul 3, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 3, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 3, 2023

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64-mps / test (default, 1, 1)

Details for Dev Infra team Raised by workflow job

@vfdev-5
Copy link
Copy Markdown
Contributor Author

vfdev-5 commented Aug 28, 2023

@pytorchbot rebase

@awgu awgu removed their request for review October 5, 2023 16:18
@vfdev-5 vfdev-5 marked this pull request as draft October 5, 2023 16:18
vfdev-5 added 2 commits October 5, 2023 16:49
@vfdev-5
Update on "Added new test sample to interpolate op in OpInfo"
38336e3 
Description:
- Added new test sample to interpolate op in OpInfo
- Fixed silent issue with zero tensor test sample for uint8 dtype

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 mcarilli ptrblck leslie-fang-intel voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler avikchaudhuri gmagogsfm ngimel

[ghstack-poisoned]
@vfdev-5
Update on "Added new test sample to interpolate op in OpInfo"
61de202 
Description:
- Added new test sample to interpolate op in OpInfo
- Fixed silent issue with zero tensor test sample for uint8 dtype

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 mcarilli ptrblck leslie-fang-intel voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler avikchaudhuri gmagogsfm ngimel

[ghstack-poisoned]
@peterbell10
Copy link
Copy Markdown
Collaborator

peterbell10 commented Oct 6, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Oct 6, 2023

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@vfdev-5
Update on "Added new test sample to interpolate op in OpInfo"
ae53a40 
Description:
- Added new test sample to interpolate op in OpInfo
- Fixed silent issue with zero tensor test sample for uint8 dtype

cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 mcarilli ptrblck leslie-fang-intel voznesenskym penguinwu EikanWang Guobing-Chen zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler avikchaudhuri gmagogsfm ngimel

[ghstack-poisoned]
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Oct 6, 2023

Successfully rebased gh/vfdev-5/10/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/104181)

@peterbell10
Copy link
Copy Markdown
Collaborator

peterbell10 commented Oct 9, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Oct 9, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet mentioned this pull request Feb 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezcano lezcano lezcano approved these changes

@pmeier pmeier pmeier approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@ngimel ngimel Awaiting requested review from ngimel

@ezyang ezyang Awaiting requested review from ezyang

@Chillee Chillee Awaiting requested review from Chillee

@kulinseth kulinseth Awaiting requested review from kulinseth

@peterbell10 peterbell10 Awaiting requested review from peterbell10

Assignees

No one assigned

Labels

ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) ciflow/slow ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor open source Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vfdev-5 @pytorchmergebot @lezcano @kit1980 @peterbell10 @pmeier @pytorchbot