Skip to content

torch.utils._content_store: fix error in hash_storage on XPU#147785

Closed
benjaminglass1 wants to merge 1 commit intomainfrom
fix_xpu_content_store
Closed

torch.utils._content_store: fix error in hash_storage on XPU#147785
benjaminglass1 wants to merge 1 commit intomainfrom
fix_xpu_content_store

Conversation

@benjaminglass1
Copy link
Copy Markdown
Collaborator

See https://github.com/pytorch/pytorch/actions/runs/13508573465/job/37745227468 for an example error. This is triggering after the merge of #147541, which enabled Dynamo compilation on XPU.

@benjaminglass1 benjaminglass1 self-assigned this Feb 24, 2025
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Feb 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147785

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit c15fceb with merge base edaf9dd (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@benjaminglass1 benjaminglass1 added topic: not user facing topic category ciflow/xpu Run XPU CI tasks labels Feb 24, 2025
@etaf etaf added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 25, 2025
@amjames amjames requested a review from albanD February 25, 2025 16:37
@etaf etaf requested a review from jansel February 25, 2025 23:35
Copy link
Copy Markdown
Contributor

@jansel jansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test?

@benjaminglass1
Copy link
Copy Markdown
Collaborator Author

@jansel Easy enough to add a test; one already existed, so I just ensured it runs on MPS and XPU.

@benjaminglass1 benjaminglass1 added the ciflow/mps Run MPS tests (subset of trunk) label Feb 26, 2025
@benjaminglass1
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / win-vs2022-cuda12.1-py3 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@benjaminglass1
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@benjaminglass1
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

See https://github.com/pytorch/pytorch/actions/runs/13508573465/job/37745227468 for an example error. This is triggering after the merge of #147541, which enabled Dynamo compilation on XPU.
@benjaminglass1
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge -i

Test failure in XPU is unrelated to this change, but another failing test that this exposes.

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 1, 4, linux.idc.xpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

aditew01 pushed a commit that referenced this pull request Feb 28, 2025
See https://github.com/pytorch/pytorch/actions/runs/13508573465/job/37745227468 for an example error. This is triggering after the merge of #147541, which enabled Dynamo compilation on XPU.

Pull Request resolved: #147785
Approved by: https://github.com/jansel
@github-actions github-actions bot deleted the fix_xpu_content_store branch March 30, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants