Add XPU to is_compile_supported to support roi_align op in torchvision#147541
Closed
frost-intel wants to merge 1 commit intopytorch:mainfrom
Closed
Add XPU to is_compile_supported to support roi_align op in torchvision#147541frost-intel wants to merge 1 commit intopytorch:mainfrom
frost-intel wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147541
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit f35eb8d with merge base 303ad19 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: Approvers from one of the following sets are needed:
|
jansel
approved these changes
Feb 21, 2025
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Feb 24, 2025
…n (#147541) Summary: Part of the required fix for intel/torch-xpu-ops#1264. To support `roi_align`, torchvision uses `is_compile_supported` in `torch/_dynamo/utils.py` to compile a non-deterministic version of the op for backwards passes. This PR adds XPU device to the supported compile devices. The `is_compile_supported()` util function has extremely limited usage, only being used in `torchvision.ops.roi_align` and `torch.utils._content_store.has_storage()`. X-link: pytorch/pytorch#147541 Approved by: https://github.com/guangyey, https://github.com/jansel Reviewed By: jeanschmidt Differential Revision: D70075274 fbshipit-source-id: 8cdb21eaa08243a7442383950f96c3351f5f52c5 Co-authored-by: lei,zhenyuan <zhenyuan.lei@intel.com>
benjaminglass1
added a commit
that referenced
this pull request
Feb 24, 2025
See https://github.com/pytorch/pytorch/actions/runs/13508573465/job/37745227468 for an example error. This is triggering after the merge of #147541, which enabled Dynamo compilation on XPU.
Collaborator
|
@frost-intel , @guangyey , this PR needs to be labeled by |
benjaminglass1
added a commit
that referenced
this pull request
Feb 26, 2025
See https://github.com/pytorch/pytorch/actions/runs/13508573465/job/37745227468 for an example error. This is triggering after the merge of #147541, which enabled Dynamo compilation on XPU.
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 26, 2025
See https://github.com/pytorch/pytorch/actions/runs/13508573465/job/37745227468 for an example error. This is triggering after the merge of #147541, which enabled Dynamo compilation on XPU. Pull Request resolved: #147785 Approved by: https://github.com/jansel
aditew01
pushed a commit
that referenced
this pull request
Feb 28, 2025
#147541) Part of the required fix for intel/torch-xpu-ops#1264. To support `roi_align`, torchvision uses `is_compile_supported` in `torch/_dynamo/utils.py` to compile a non-deterministic version of the op for backwards passes. This PR adds XPU device to the supported compile devices. The `is_compile_supported()` util function has extremely limited usage, only being used in `torchvision.ops.roi_align` and `torch.utils._content_store.has_storage()`. Pull Request resolved: #147541 Approved by: https://github.com/guangyey, https://github.com/jansel Co-authored-by: lei,zhenyuan <zhenyuan.lei@intel.com>
aditew01
pushed a commit
that referenced
this pull request
Feb 28, 2025
See https://github.com/pytorch/pytorch/actions/runs/13508573465/job/37745227468 for an example error. This is triggering after the merge of #147541, which enabled Dynamo compilation on XPU. Pull Request resolved: #147785 Approved by: https://github.com/jansel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the required fix for intel/torch-xpu-ops#1264.
To support
roi_align, torchvision usesis_compile_supportedintorch/_dynamo/utils.pyto compile a non-deterministic version of the op for backwards passes. This PR adds XPU device to the supported compile devices.The
is_compile_supported()util function has extremely limited usage, only being used intorchvision.ops.roi_alignandtorch.utils._content_store.has_storage().cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames