[inductor][subgraph] Plumbing to get ShapeAsConstantBuffer from subgraph to main graph output#147559
Closed
anijain2305 wants to merge 4 commits intogh/anijain2305/685/basefrom
Closed
[inductor][subgraph] Plumbing to get ShapeAsConstantBuffer from subgraph to main graph output#147559anijain2305 wants to merge 4 commits intogh/anijain2305/685/basefrom
anijain2305 wants to merge 4 commits intogh/anijain2305/685/basefrom
Conversation
…aph to main graph output [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147559
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit adb0901 with merge base 30375cb ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
eellison
reviewed
Feb 24, 2025
torch/_inductor/ir.py
Outdated
| except NotImplementedError: | ||
| pass | ||
| if isinstance(x, StorageBox): | ||
| if isinstance(x.data, ShapeAsConstantBuffer): |
Contributor
There was a problem hiding this comment.
do you know why we're mapping ShapeAsConstantBuffer with StorageBox ? that seems weird
Contributor
Author
There was a problem hiding this comment.
It happens here. I can prevent wrapping of symints here. Is that more intuitive?
pytorch/torch/_inductor/lowering.py
Line 6779 in 2978771
desai0007
pushed a commit
to desai0007/test-repo-pytorch
that referenced
this pull request
Feb 26, 2025
…aph to main graph output ghstack-source-id: 543f908 Pull Request resolved: pytorch/pytorch#147559
… from subgraph to main graph output" I am unable to create a test case that fails without the next PR. The idea is to have a symint which is returned by the inner subgraph and then returned by the forward graph after partitioning. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
… from subgraph to main graph output" I am unable to create a test case that fails without the next PR. The idea is to have a symint which is returned by the inner subgraph and then returned by the forward graph after partitioning. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
… from subgraph to main graph output" I am unable to create a test case that fails without the next PR. The idea is to have a symint which is returned by the inner subgraph and then returned by the forward graph after partitioning. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
Contributor
Author
|
@eellison This should be ready now. |
eellison
approved these changes
Mar 1, 2025
| class TensorBox(MutableBox): | ||
| @staticmethod | ||
| def create(data): # type: ignore[no-untyped-def] | ||
| if isinstance(data, ShapeAsConstantBuffer): |
Contributor
There was a problem hiding this comment.
do you know when we create these ? just curious
Contributor
Author
There was a problem hiding this comment.
I think in realize_input of ExternKernel. If that input happens to be output as well, then this PR is needed to make it work.
Contributor
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 1 checks: Lint / lintrunner-noclang / linux-job Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 3, 2025
Pull Request resolved: #139325 Approved by: https://github.com/bdhirsh, https://github.com/zou3519 ghstack dependencies: #147559
pytorchmergebot
pushed a commit
to min-jean-cho/pytorch
that referenced
this pull request
Mar 5, 2025
Pull Request resolved: pytorch#139325 Approved by: https://github.com/bdhirsh, https://github.com/zou3519 ghstack dependencies: pytorch#147559
jurgen-paul
pushed a commit
to jurgen-paul/pytorch.git.file
that referenced
this pull request
Mar 19, 2025
…aph to main graph output ghstack-source-id: 191c9ea Pull Request resolved: pytorch/pytorch#147559
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I am unable to create a test case that fails without the next PR. The idea is to have a symint which is returned by the inner subgraph and then returned by the forward graph after partitioning.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov