[invoke_subgraph] Run joint passes on the hop graphs#139325
Closed
anijain2305 wants to merge 43 commits intogh/anijain2305/571/basefrom
Closed
[invoke_subgraph] Run joint passes on the hop graphs#139325anijain2305 wants to merge 43 commits intogh/anijain2305/571/basefrom
anijain2305 wants to merge 43 commits intogh/anijain2305/571/basefrom
Conversation
[ghstack-poisoned]
This was referenced Oct 30, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139325
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7dc0e1a with merge base 30375cb ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 30, 2024
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
bdhirsh
reviewed
Nov 1, 2024
bdhirsh
reviewed
Nov 1, 2024
bdhirsh
reviewed
Nov 1, 2024
| def propagate_meta_info(new_hop_gm, new_call_function_node, old_call_function_node): | ||
| # Copy all the fields from the old call_function node. And then override | ||
| # the `val` meta field with the outputs of new_hop_gm. | ||
| new_call_function_node.meta = copy.copy(old_call_function_node.meta) |
Collaborator
There was a problem hiding this comment.
I wonder if we really need to copy.copy() all of the metadata here. Presumably we aren't mutating the FakeTensors that we stashed onto the graph?
Collaborator
There was a problem hiding this comment.
as a datapoint, when we propagate metadata natively in FX when retracing, we just use the exact same values in the meta dict directly: https://github.com/pytorch/pytorch/blob/main/torch/fx/node.py#L718
Contributor
There was a problem hiding this comment.
+1, if we can avoid the copy that would be better
bdhirsh
reviewed
Nov 1, 2024
bdhirsh
reviewed
Nov 1, 2024
bdhirsh
reviewed
Nov 1, 2024
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
zou3519
approved these changes
Mar 3, 2025
Contributor
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 1 checks: Lint / lintrunner-noclang / linux-job Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
to min-jean-cho/pytorch
that referenced
this pull request
Mar 5, 2025
Pull Request resolved: pytorch#139325 Approved by: https://github.com/bdhirsh, https://github.com/zou3519 ghstack dependencies: pytorch#147559
Divigroup-RAP
pushed a commit
to Divigroup-RAP/PYTORCH
that referenced
this pull request
Apr 22, 2025
ghstack-source-id: a393f32 Pull Request resolved: pytorch/pytorch#139325
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames