windows Magma and cuda build for cu128 by tinglvv · Pull Request #146653 · pytorch/pytorch

tinglvv · 2025-02-06T23:33:34Z

removing .ci/pytorch/windows/internal/cuda_install.bat as it is a duplicate with .github/scripts/windows/cuda_install.bat. The later one is the one in use - https://github.com/pytorch/pytorch/pull/146653/files#diff-613791f266f2f7b81148ca8f447b0cd6c6544f824f5f46a78a2794006c78957bR8

cc @atalman @ptrblck @nWEIdia

pytorch-bot · 2025-02-06T23:33:37Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146653

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 181 Pending

As of commit 126d019 with merge base 99dd846 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

atalman

lgtm

atalman · 2025-02-07T18:07:46Z

@pytorchmergebot merge -f "All the jobs are green"

pytorchmergebot · 2025-02-07T18:09:19Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

atalman · 2025-02-07T19:35:39Z

@pytorchmergebot revert -c nosignal -m "Broke nightly builds"

pytorchmergebot · 2025-02-07T19:37:13Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2025-02-07T19:37:19Z

@tinglvv your PR has been successfully reverted.

This reverts commit 9e27d36. Reverted #146653 on behalf of https://github.com/atalman due to Broke nightly builds ([comment](#146653 (comment)))

atalman · 2025-02-10T13:47:15Z

@pytorchmergebot merge -f "All the jobs are green"

pytorchmergebot · 2025-02-10T13:48:43Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-02-10T17:36:28Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2025-02-10T17:36:34Z

@tinglvv your PR has been successfully reverted.

This reverts commit d0e70c4. Reverted #146653 on behalf of https://github.com/jeanschmidt due to Seems to have broken some windows tests, reverting to see if it gets green ([comment](#146653 (comment)))

atalman · 2025-02-10T18:28:12Z

Looks like failure maybe not related:

1a64:15a8 @ 03109843 - LdrpFindKnownDll - ENTER: DLL name: bcrypt.dll
1a64:15a8 @ 03109843 - LdrpFindKnownDll - RETURN: Status: 0x00000000
1a64:15a8 @ 03109843 - LdrpMinimalMapModule - ENTER: DLL name: C:\Windows\System32\bcrypt.dll
ModLoad: 00007ffc`780c0000 00007ffc`780e6000   C:\Windows\System32\bcrypt.dll
1a64:15a8 @ 03109843 - LdrpMinimalMapModule - RETURN: Status: 0x00000000
1a64:15a8 @ 03109843 - LdrpFindDllActivationContext - INFO: Probing for the manifest of DLL "C:\Windows\System32\bcrypt.dll" failed with status 0xc000008a

jeanschmidt · 2025-02-10T18:32:46Z

Seems unrelated:

https://github.com/pytorch/pytorch/actions/runs/13246927668/job/36977751039

jeanschmidt · 2025-02-10T18:33:17Z

@pytorchbot merge -f "re-merge, signals parsed"

pytorchmergebot · 2025-02-10T18:34:46Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Followup after: #146653 This should fix upcoming CUDA 12.8 windows builds. Issue found during pytorch-canary Windows AMI test. Pull Request resolved: #146906 Approved by: https://github.com/malfet, https://github.com/tinglvv

Scripts needed to build Magma and CUDA on windows Same as #146653 Pull Request resolved: #155799 Approved by: https://github.com/jeanschmidt

windows Magma build for cu128

36ea463

tinglvv requested a review from a team as a code owner February 6, 2025 23:33

pytorch-bot bot added the release notes: releng release notes category label Feb 6, 2025

fix typo

efb36cc

tinglvv mentioned this pull request Feb 6, 2025

Enable CUDA 12.8.0, Disable CUDA 12.4 #145570

Closed

26 tasks

pytorchbot added the open source label Feb 6, 2025

atalman approved these changes Feb 7, 2025

View reviewed changes

pytorchmergebot added the merging label Feb 7, 2025

pytorchmergebot added the Merged label Feb 7, 2025

pytorchmergebot closed this in 9e27d36 Feb 7, 2025

pytorchmergebot removed the merging label Feb 7, 2025

pytorchmergebot added a commit that referenced this pull request Feb 7, 2025

Revert "windows Magma build for cu128 (#146653)"

f17109b

This reverts commit 9e27d36. Reverted #146653 on behalf of https://github.com/atalman due to Broke nightly builds ([comment](#146653 (comment)))

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Feb 7, 2025

pytorchmergebot reopened this Feb 7, 2025

atalman added 2 commits February 7, 2025 11:56

test

39ef888

fix

126d019

atalman added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Feb 7, 2025

pytorchmergebot added the merging label Feb 10, 2025

pytorchmergebot closed this in d0e70c4 Feb 10, 2025

pytorchmergebot reopened this Feb 10, 2025

jeanschmidt added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 10, 2025

pytorchmergebot added the merging label Feb 10, 2025

pytorchmergebot closed this in 519f547 Feb 10, 2025

pytorchmergebot removed the merging label Feb 10, 2025

atalman mentioned this pull request Feb 11, 2025

Fix var CUDA_PATH_V128 in cuda128.bat file #146906

Closed

tinglvv changed the title ~~windows Magma build for cu128~~ windows Magma and cuda build for cu128 May 6, 2025

atalman mentioned this pull request Jun 12, 2025

[CD] Windows Magma build 12.9 and cuda scripts #155799

Closed

pytorchmergebot pushed a commit that referenced this pull request Jun 12, 2025

[CD] Windows Magma build 12.9 and cuda scripts (#155799)

0d3d84d

Scripts needed to build Magma and CUDA on windows Same as #146653 Pull Request resolved: #155799 Approved by: https://github.com/jeanschmidt

Conversation

tinglvv commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146653

⏳ No Failures, 181 Pending

Uh oh!

atalman left a comment

Choose a reason for hiding this comment

Uh oh!

atalman commented Feb 7, 2025

Uh oh!

pytorchmergebot commented Feb 7, 2025

Merge started

Uh oh!

atalman commented Feb 7, 2025

Uh oh!

pytorchmergebot commented Feb 7, 2025

Uh oh!

pytorchmergebot commented Feb 7, 2025

Uh oh!

atalman commented Feb 10, 2025

Uh oh!

pytorchmergebot commented Feb 10, 2025

Merge started

Uh oh!

pytorchmergebot commented Feb 10, 2025

Uh oh!

pytorchmergebot commented Feb 10, 2025

Uh oh!

atalman commented Feb 10, 2025

Uh oh!

jeanschmidt commented Feb 10, 2025

Uh oh!

jeanschmidt commented Feb 10, 2025

Uh oh!

pytorchmergebot commented Feb 10, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tinglvv commented Feb 6, 2025 •

edited

Loading

pytorch-bot bot commented Feb 6, 2025 •

edited

Loading