Skip to content

Fix var CUDA_PATH_V128 in cuda128.bat file#146906

Closed
atalman wants to merge 1 commit intomainfrom
atalman-patch-4
Closed

Fix var CUDA_PATH_V128 in cuda128.bat file#146906
atalman wants to merge 1 commit intomainfrom
atalman-patch-4

Conversation

@atalman
Copy link
Copy Markdown
Contributor

@atalman atalman commented Feb 11, 2025 •
edited
Loading

Followup after: #146653
This should fix upcoming CUDA 12.8 windows builds.
Issue found during pytorch-canary Windows AMI test.

@atalman
Fix var CUDA_PATH_V128 in cuda128.bat file
57f4a78 
This should fix upcoming CUDA 12.8 windows builds.
@atalman atalman requested a review from a team as a code owner February 11, 2025 16:13
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Feb 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146906

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Pending, 1 Unrelated Failure

As of commit 57f4a78 with merge base 861bf89 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman atalman added the topic: not user facing topic category label Feb 11, 2025
malfet
malfet approved these changes Feb 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder if we can avoid code duplication here

@atalman
Copy link
Copy Markdown
Contributor Author

atalman commented Feb 11, 2025

Hi @malfet agree we should refactor this batch script logic

tinglvv
tinglvv approved these changes Feb 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@tinglvv tinglvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, stamped. Let me try to refactor to see if we could avoid code duplication as a next step..

@atalman
Copy link
Copy Markdown
Contributor Author

atalman commented Feb 11, 2025

@pytorchmergebot merge -f "lint is green, failures are not related"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 11, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@tinglvv tinglvv mentioned this pull request Feb 12, 2025
Closed
26 tasks
@github-actions github-actions bot deleted the atalman-patch-4 branch March 14, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@tinglvv tinglvv tinglvv approved these changes

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @pytorchmergebot @malfet @tinglvv