Skip to content

Add type annotations for higher order ops/flex_attention#137065

Closed
Chillee wants to merge 7 commits intogh/chillee/359/basefrom
gh/chillee/359/head
Closed

Add type annotations for higher order ops/flex_attention#137065
Chillee wants to merge 7 commits intogh/chillee/359/basefrom
gh/chillee/359/head

Conversation

@Chillee
Copy link
Collaborator

@Chillee Chillee commented Oct 1, 2024 •
edited by pytorch-bot bot
Loading

@Chillee Chillee requested a review from zou3519 as a code owner October 1, 2024 00:51
This was referenced Oct 1, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137065

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 47f50d5 with merge base b825848 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Chillee Chillee mentioned this pull request Oct 1, 2024
Closed
@github-actions github-actions bot requested a review from ezyang October 1, 2024 00:51
@drisspg drisspg added the topic: not user facing topic category label Oct 1, 2024
@Chillee Chillee added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 1, 2024
Chillee added a commit that referenced this pull request Oct 1, 2024
@Chillee
Add type annotations for higher order ops/flex_attention
57a3a08 
ghstack-source-id: 5845bc5
Pull Request resolved: #137065
This was referenced Oct 1, 2024
Closed
Closed
Skylion007
Skylion007 reviewed Oct 1, 2024
View reviewed changes
@Chillee
Update on "Add type annotations for higher order ops/flex_attention"
47f50d5 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@Chillee
Copy link
Collaborator Author

Chillee commented Oct 2, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@Chillee
Copy link
Collaborator Author

Chillee commented Oct 2, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 2, 2024

Merge started

Your change will be merged while ignoring the following 3 checks: pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 3, 5, lf.linux.g5.4xlarge.nvidia.gpu), inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100), trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 2, 5, lf.linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@Chillee @AnantGulati
Add type annotations for higher order ops/flex_attention (pytorch#137065
dffc22f 
)

Pull Request resolved: pytorch#137065
Approved by: https://github.com/drisspg, https://github.com/Skylion007
ghstack dependencies: pytorch#136826, pytorch#137043, pytorch#137049
pytorchmergebot pushed a commit that referenced this pull request Oct 2, 2024
@Chillee @pytorchmergebot
Fix typo in _normalize ref (#137079)
2b329d3 
I think this should basically make no difference numerically, but it does have some ramifications on things like CSE.
Pull Request resolved: #137079
Approved by: https://github.com/Skylion007
ghstack dependencies: #136826, #137043, #137049, #137065
@github-actions github-actions bot deleted the gh/chillee/359/head branch November 6, 2024 02:06
Esquains pushed a commit to Esquains/study1 that referenced this pull request Dec 15, 2024
@Chillee
Add type annotations for higher order ops/flex_attention
fe4b162 
ghstack-source-id: 9a99d68
Pull Request resolved: pytorch/pytorch#137065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@drisspg drisspg drisspg approved these changes

@zou3519 zou3519 Awaiting requested review from zou3519

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Chillee @pytorchmergebot @Skylion007 @drisspg