Skip to content

set FlexAttention devices properly during tracing#137049

Closed
Chillee wants to merge 4 commits intogh/chillee/358/basefrom
gh/chillee/358/head
Closed

set FlexAttention devices properly during tracing#137049
Chillee wants to merge 4 commits intogh/chillee/358/basefrom
gh/chillee/358/head

Conversation

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Sep 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137049

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 40c3ce5 with merge base b825848 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions Bot requested a review from ezyang September 30, 2024 21:16
Chillee added a commit that referenced this pull request Sep 30, 2024
ghstack-source-id: 8733634
Pull Request resolved: #137049
@Chillee Chillee added the topic: not user facing topic category label Sep 30, 2024
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
Comment thread torch/_higher_order_ops/flex_attention.py Outdated
@Chillee Chillee added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 1, 2024
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@Chillee
Copy link
Copy Markdown
Collaborator Author

Chillee commented Oct 1, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
pytorchmergebot pushed a commit that referenced this pull request Oct 2, 2024
I think this should basically make no difference numerically, but it does have some ramifications on things like CSE.
Pull Request resolved: #137079
Approved by: https://github.com/Skylion007
ghstack dependencies: #136826, #137043, #137049, #137065
@github-actions github-actions Bot deleted the gh/chillee/358/head branch November 3, 2024 02:14
Esquains pushed a commit to Esquains/study1 that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants