Skip to content

Format torch.fx.experimental.validator#136935

Closed
ezyang wants to merge 4 commits intogh/ezyang/2947/basefrom
gh/ezyang/2947/head
Closed

Format torch.fx.experimental.validator#136935
ezyang wants to merge 4 commits intogh/ezyang/2947/basefrom
gh/ezyang/2947/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 29, 2024 •
edited
Loading

@ezyang
Update
84f5a5b 
[ghstack-poisoned]
This was referenced Sep 29, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136935

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 155 Pending

As of commit 3e3a06a with merge base failed to retrieve merge base, please contact dev infra:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels Sep 29, 2024
@ezyang
Update
ef21676 
[ghstack-poisoned]
@ezyang ezyang added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Sep 29, 2024
@ezyang
Update
2f6be20 
[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Sep 30, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

Merge started

Your change will be merged while ignoring the following 1 checks: Lint / Test run_test.py is usable without boto3/rockset

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ezyang ezyang mentioned this pull request Sep 30, 2024
Closed
@ezyang
Copy link
Contributor Author

ezyang commented Sep 30, 2024

@pytorchbot merge -f "lint passed, and I have previous green signal"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@ezyang @pytorchmergebot
Turn on type-checking in torch.fx.experimental.symbolic_shapes (#136972)
3ff2d93 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #136972
Approved by: https://github.com/Skylion007
ghstack dependencies: #136917, #136934, #136935
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

@ezyang your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Sep 30, 2024
@pytorchmergebot
Revert "Format torch.fx.experimental.validator (#136935)"
c94536a 
This reverts commit 377e4bc.

Reverted #136935 on behalf of https://github.com/ezyang due to merge conflict revert ([comment](#136934 (comment)))
@ezyang
Update
3e3a06a 
[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Oct 1, 2024
Closed
@ezyang
Copy link
Contributor Author

ezyang commented Oct 1, 2024

@pytorchbot merge -f "lint is clean"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 1, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Oct 1, 2024
@ezyang @pytorchmergebot
Turn on type-checking in torch.fx.experimental.symbolic_shapes (#136972)
cc8f1cd 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #136972
Approved by: https://github.com/Skylion007
ghstack dependencies: #136934, #136935
pytorchmergebot pushed a commit that referenced this pull request Oct 1, 2024
@ezyang @pytorchmergebot
Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes (#…
6bd9d37 
…137019)

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #137019
Approved by: https://github.com/Skylion007
ghstack dependencies: #136934, #136935, #136972
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Turn on type-checking in torch.fx.experimental.symbolic_shapes (pytor…
411cb88 
…ch#136972)

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: pytorch#136972
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136917, pytorch#136934, pytorch#136935
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@pytorchmergebot @AnantGulati
Revert "Format torch.fx.experimental.validator (pytorch#136935)"
f091a43 
This reverts commit 377e4bc.

Reverted pytorch#136935 on behalf of https://github.com/ezyang due to merge conflict revert ([comment](pytorch#136934 (comment)))
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Format torch.fx.experimental.validator (pytorch#136935)
cfb787a 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: pytorch#136935
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136934
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Turn on type-checking in torch.fx.experimental.symbolic_shapes (pytor…
33e7cbd 
…ch#136972)

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: pytorch#136972
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136934, pytorch#136935
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Remove allow-untyped-defs from torch.fx.experimental.symbolic_shapes (p…
a5e103d 
…ytorch#137019)

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: pytorch#137019
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136934, pytorch#136935, pytorch#136972
@github-actions github-actions bot deleted the gh/ezyang/2947/head branch November 3, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @pytorchmergebot @Skylion007