Skip to content

Propagate detailed location information of shape guards to guards/recompiles output#136917

Closed
ezyang wants to merge 6 commits intogh/ezyang/2944/basefrom
gh/ezyang/2944/head
Closed

Propagate detailed location information of shape guards to guards/recompiles output#136917
ezyang wants to merge 6 commits intogh/ezyang/2944/basefrom
gh/ezyang/2944/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 28, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

To see the payoff, look at test/dynamo/test_logging.py

The general idea is to refactor produce_guards into produce_guards_verbose which also returns verbose code parts, which have our annotations.

The rest of the logic is plumbing around SLocs to the places they need to be so we can print them. Guards are easy; value ranges and duck sizing take more care.

Signed-off-by: Edward Z. Yang ezyang@meta.com

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec

@ezyang
Update
006eb3e 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 28, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136917

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 170 Pending

As of commit 010a245 with merge base failed to retrieve merge base, please contact dev infra:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang
Update
14c95e5 
[ghstack-poisoned]
@ezyang
Update
0e8073d 
[ghstack-poisoned]
ezyang added a commit that referenced this pull request Sep 28, 2024
@ezyang
Propagate detailed location information of shape guards to guards/rec…
d3bf563 
…ompiles output

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 102b7b8
Pull Request resolved: #136917
@ezyang
Update
d4b509d 
[ghstack-poisoned]
@ezyang ezyang added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Sep 28, 2024
@ezyang
Update
d655e8f 
[ghstack-poisoned]
@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 29, 2024
@ezyang ezyang requested a review from anijain2305 September 29, 2024 03:19
This was referenced Sep 29, 2024
Closed
Closed
anijain2305
anijain2305 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dynamo parts LGTM.

@ezyang
Copy link
Contributor Author

ezyang commented Sep 29, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 29, 2024

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#136928

Details for Dev Infra team Raised by workflow job

@ezyang
Update
010a245 
[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Sep 29, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 29, 2024

Merge started

Your change will be merged while ignoring the following 2 checks: Lint / Test run_test.py is usable without boto3/rockset, inductor-periodic / cuda12.1-py3.10-gcc9-sm80 / test (inductor_torchbench_smoketest_perf, 1, 1, linux.gcp.a100)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 29, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / cuda12.1-py3.10-gcc9-sm86 / test (aot_inductor_torchbench, 2, 2, lf.linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Sep 30, 2024

@pytorchbot merge -f "unrelated problems"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 30, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@ezyang @pytorchmergebot
Format torch.fx.experimental.symbolic_shapes with PYFMT (#136934)
cf1a7ea 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: #136934
Approved by: https://github.com/Skylion007
ghstack dependencies: #136917
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@ezyang @pytorchmergebot
Format torch.fx.experimental.validator (#136935)
377e4bc 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: #136935
Approved by: https://github.com/Skylion007
ghstack dependencies: #136917, #136934
pytorchmergebot pushed a commit that referenced this pull request Sep 30, 2024
@ezyang @pytorchmergebot
Turn on type-checking in torch.fx.experimental.symbolic_shapes (#136972)
3ff2d93 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #136972
Approved by: https://github.com/Skylion007
ghstack dependencies: #136917, #136934, #136935
AnantGulati pushed a commit to AnantGulati/pytorch that referenced this pull request Oct 2, 2024
@ezyang @AnantGulati
Turn on type-checking in torch.fx.experimental.symbolic_shapes (pytor…
411cb88 
…ch#136972)

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: pytorch#136972
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#136917, pytorch#136934, pytorch#136935
@github-actions github-actions bot deleted the gh/ezyang/2944/head branch November 3, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anijain2305 anijain2305 anijain2305 approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@isuruf isuruf Awaiting requested review from isuruf

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

@angelayi angelayi Awaiting requested review from angelayi

@pianpwk pianpwk Awaiting requested review from pianpwk

@Chillee Chillee Awaiting requested review from Chillee

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: fx release notes category suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ezyang @pytorchmergebot @anijain2305