Skip to content

Disable iOS workflow#136571

Closed
malfet wants to merge 2 commits intomainfrom
malfet-patch-28
Closed

Disable iOS workflow#136571
malfet wants to merge 2 commits intomainfrom
malfet-patch-28

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Sep 24, 2024 •
edited
Loading

See #136284
It's been broken for more than a week and it does not seem like anyone cares about fixing it.
Once it's landed I'll reassigned the issue on oncall: mobile

@malfet malfet requested a review from a team as a code owner September 24, 2024 20:34
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 24, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136571

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 6a56252 with merge base 7ff8e66 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Sep 24, 2024
@malfet malfet changed the title Disable simulator workflow Disable iOS workflow Sep 25, 2024
@malfet
Copy link
Contributor Author

malfet commented Sep 25, 2024

@pytorchbot merge -f "Lint is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 25, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet mentioned this pull request Sep 25, 2024
Closed
BoyuanFeng pushed a commit to BoyuanFeng/pytorch that referenced this pull request Sep 25, 2024
@malfet @BoyuanFeng
Disable iOS workflow (pytorch#136571)
64f2045 
See pytorch#136284
It's been broken for more than a week and it does not seem like anyone cares about fixing it.
Once it's landed I'll reassigned the issue on `oncall: mobile`
Pull Request resolved: pytorch#136571
Approved by: https://github.com/huydhn, https://github.com/kit1980
@kit1980
Copy link
Contributor

kit1980 commented Sep 26, 2024

@pytorchmergebot cherry-pick --onto release/2.5 -c critical

pytorchbot pushed a commit that referenced this pull request Sep 26, 2024
@malfet @pytorchbot
Disable iOS workflow (#136571)
7692ae2 
See #136284
It's been broken for more than a week and it does not seem like anyone cares about fixing it.
Once it's landed I'll reassigned the issue on `oncall: mobile`
Pull Request resolved: #136571
Approved by: https://github.com/huydhn, https://github.com/kit1980

(cherry picked from commit 5340feb)
@pytorchbot
Copy link
Collaborator

pytorchbot commented Sep 26, 2024

Cherry picking #136571

The cherry pick PR is at #136706 and it is recommended to link a critical cherry pick PR with an issue.

Details for Dev Infra team Raised by workflow job

kit1980 pushed a commit that referenced this pull request Sep 26, 2024
@pytorchbot @malfet
Disable iOS workflow (#136706)
cbe476a 
Disable iOS workflow (#136571)

See #136284
It's been broken for more than a week and it does not seem like anyone cares about fixing it.
Once it's landed I'll reassigned the issue on `oncall: mobile`
Pull Request resolved: #136571
Approved by: https://github.com/huydhn, https://github.com/kit1980

(cherry picked from commit 5340feb)

Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
@kit1980 kit1980 mentioned this pull request Sep 26, 2024
Closed
@GregoryComer
Copy link
Member

GregoryComer commented Sep 27, 2024

@malfet I have been looking into this. I landed a fix upstream in XNNPACK and am reverting the update on the release branch (#136522, listed in the tracker). Will fix on the main with the next dependency update. I will re-enable the test then.

@github-actions github-actions bot deleted the malfet-patch-28 branch November 3, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@malfet @pytorchmergebot @kit1980 @pytorchbot @GregoryComer @huydhn