[RELEASE ONLY CHANGES] Revert XNNPACK Update#136522
Merged
kit1980 merged 2 commits intopytorch:release/2.5from Sep 27, 2024
Merged
[RELEASE ONLY CHANGES] Revert XNNPACK Update#136522kit1980 merged 2 commits intopytorch:release/2.5from
kit1980 merged 2 commits intopytorch:release/2.5from
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136522
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 4 Unrelated FailuresAs of commit b16142a with merge base b7eb725 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…dentifier (pytorch#134724)" This reverts commit 679b8fe.
This reverts commit 3b40b07.
4b2457d to
b16142a
Compare
Member
Author
|
As noted in description, I have confirmed test failures are pre-existing with the same failure message by running CI on the base commit with a dummy PR here: #136569. |
mcr229
reviewed
Sep 25, 2024
mcr229
approved these changes
Sep 26, 2024
Closed
kit1980
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing XNNPACK update revert on release/2.5. This fixes the issue with periodic/ios-build-test related to a CMake regressoin in XNNPACK. This is also applying -O2 flags to libtorch_cpu whenever XNNPACK is linked. I have already contributed and merged a fix upstream, but they did a sizable build refactor in the last couple of weeks that I want to avoid pulling in at the last minute. I will update the dependency version on main, but am planning to just revert for 2.5.
This change landed right before branch cut and should be independent / drop-in. No source changes happened for the update (only build updates). As such, if full CI is clean, this should be the safest way to fix the issue on the release branch.
I've added extra ciflow tags to run more tests here, which has surfaced failures. I've run CI with the same tags on #136569 (dummy change) to confirm that "new" failures are pre-existing. Note that the failures fail with the same error message.
cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @rec @LucasLLC @MeetVadakkanchery @mhorowitz @pradeepfn