[ONNX] Fix numpy method to return the correct type#136162
Closed
justinchuby wants to merge 6 commits intopytorch:mainfrom
Closed
[ONNX] Fix numpy method to return the correct type#136162justinchuby wants to merge 6 commits intopytorch:mainfrom
justinchuby wants to merge 6 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136162
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit fa7bc39 with merge base 0aa41eb ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
justinchuby
commented
Sep 16, 2024
xadupre
approved these changes
Sep 17, 2024
Collaborator
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 1 checks: trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 4, 5, linux.4xlarge.nvidia.gpu) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Sep 17, 2024
Previous implementation of the `numpy()` method returns `fp64` when the tensor is `fp32`. This is unexpected but seems to be caused by calling `__array__(dtype=None)` on the numpy array. I updated the implementation to implement the `numpy()` method explicitly and added tests to guard the behavior. This needs to be cherry-picked into torch 2.5 Pull Request resolved: pytorch#136162 Approved by: https://github.com/gramalingam, https://github.com/xadupre (cherry picked from commit 67b14ce)
justinchuby
added a commit
to justinchuby/torch-onnx
that referenced
this pull request
Sep 18, 2024
justinchuby
added a commit
to justinchuby/torch-onnx
that referenced
this pull request
Sep 18, 2024
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
Previous implementation of the `numpy()` method returns `fp64` when the tensor is `fp32`. This is unexpected but seems to be caused by calling `__array__(dtype=None)` on the numpy array. I updated the implementation to implement the `numpy()` method explicitly and added tests to guard the behavior. This needs to be cherry-picked into torch 2.5 Pull Request resolved: pytorch#136162 Approved by: https://github.com/gramalingam, https://github.com/xadupre
kit1980
pushed a commit
that referenced
this pull request
Sep 20, 2024
[ONNX] Fix numpy method to return the correct type (#136162) Previous implementation of the `numpy()` method returns `fp64` when the tensor is `fp32`. This is unexpected but seems to be caused by calling `__array__(dtype=None)` on the numpy array. I updated the implementation to implement the `numpy()` method explicitly and added tests to guard the behavior. This needs to be cherry-picked into torch 2.5 Pull Request resolved: #136162 Approved by: https://github.com/gramalingam, https://github.com/xadupre (cherry picked from commit 67b14ce)
56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous implementation of the
numpy()method returnsfp64when the tensor isfp32. This is unexpected but seems to be caused by calling__array__(dtype=None)on the numpy array. I updated the implementation to implement thenumpy()method explicitly and added tests to guard the behavior.This needs to be cherry-picked into torch 2.5