[ONNX] Fix numpy method to return the correct type (#136162) #136203
Merged
kit1980 merged 2 commits intopytorch:release/2.5from Sep 20, 2024
Merged
[ONNX] Fix numpy method to return the correct type (#136162) #136203kit1980 merged 2 commits intopytorch:release/2.5from
kit1980 merged 2 commits intopytorch:release/2.5from
Conversation
Previous implementation of the `numpy()` method returns `fp64` when the tensor is `fp32`. This is unexpected but seems to be caused by calling `__array__(dtype=None)` on the numpy array. I updated the implementation to implement the `numpy()` method explicitly and added tests to guard the behavior. This needs to be cherry-picked into torch 2.5 Pull Request resolved: pytorch#136162 Approved by: https://github.com/gramalingam, https://github.com/xadupre (cherry picked from commit 67b14ce)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136203
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit dd76e40 with merge base b7eb725 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.