Skip to content

[Inductor] Increase multiplier to 3 for Inductor AMP FP16 benchmark correctness check#135932

Closed
jiayisunx wants to merge 1 commit intogh/jiayisunx/30/basefrom
gh/jiayisunx/30/head
Closed

[Inductor] Increase multiplier to 3 for Inductor AMP FP16 benchmark correctness check#135932
jiayisunx wants to merge 1 commit intogh/jiayisunx/30/basefrom
gh/jiayisunx/30/head

Conversation

@jiayisunx
Copy link
Collaborator

@jiayisunx jiayisunx commented Sep 13, 2024

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135932

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit a973db3 with merge base bf68e16 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jiayisunx added a commit that referenced this pull request Sep 13, 2024
…orrectness check

ghstack-source-id: 56f35df
Pull Request resolved: #135932
@jiayisunx jiayisunx requested a review from jansel September 13, 2024 05:59
@jiayisunx
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 18, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@jiayisunx
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jiayisunx added a commit to jiayisunx/pytorch that referenced this pull request Sep 18, 2024
…orrectness check (pytorch#135932)

Fix pytorch#135657.
Aligned with AMP BF16, using multiplier 3 for Inductor AMP FP16 benchmark correctness check

Pull Request resolved: pytorch#135932
Approved by: https://github.com/CaoE, https://github.com/jgong5, https://github.com/jansel
facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Sep 18, 2024
…check (#135932)

Summary:
Fix pytorch/pytorch#135657.
Aligned with AMP BF16, using multiplier 3 for Inductor AMP FP16 benchmark correctness check

X-link: pytorch/pytorch#135932
Approved by: https://github.com/CaoE, https://github.com/jgong5, https://github.com/jansel

Reviewed By: jeanschmidt

Differential Revision: D62980154

fbshipit-source-id: e7fb9cd8faea933ff85fb1173620bf0d54ebf9f1
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
…orrectness check (pytorch#135932)

Fix pytorch#135657.
Aligned with AMP BF16, using multiplier 3 for Inductor AMP FP16 benchmark correctness check

Pull Request resolved: pytorch#135932
Approved by: https://github.com/CaoE, https://github.com/jgong5, https://github.com/jansel
kit1980 pushed a commit that referenced this pull request Sep 20, 2024
…orrectness check (#135932) (#136262)

Fix #135657.
Aligned with AMP BF16, using multiplier 3 for Inductor AMP FP16 benchmark correctness check

Pull Request resolved: #135932
Approved by: https://github.com/CaoE, https://github.com/jgong5, https://github.com/jansel
@github-actions github-actions bot deleted the gh/jiayisunx/30/head branch October 19, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants