Skip to content

[Inductor] Increase multiplier to 3 for Inductor AMP FP16 benchmark correctness check (#135932)#136262

Merged
kit1980 merged 1 commit intopytorch:release/2.5from
jiayisunx:jiayi/fp16
Sep 20, 2024
Merged

[Inductor] Increase multiplier to 3 for Inductor AMP FP16 benchmark correctness check (#135932)#136262
kit1980 merged 1 commit intopytorch:release/2.5from
jiayisunx:jiayi/fp16

Conversation

@jiayisunx
Copy link
Collaborator

@jiayisunx jiayisunx commented Sep 18, 2024

This PR fixes the accuracy failure for 3 models of Inductor AMP FP16 benchmark on CPU.
Fix #135657. Aligned with AMP BF16, using multiplier 3 for Inductor AMP FP16 benchmark correctness check

Pull Request resolved: #135932
Approved by: https://github.com/CaoE, https://github.com/jgong5, https://github.com/jansel

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @chenyang78 @kadeng @chauhang @amjames @rec

…orrectness check (pytorch#135932)

Fix pytorch#135657.
Aligned with AMP BF16, using multiplier 3 for Inductor AMP FP16 benchmark correctness check

Pull Request resolved: pytorch#135932
Approved by: https://github.com/CaoE, https://github.com/jgong5, https://github.com/jansel
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136262

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 1612a85 with merge base b7eb725 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jiayisunx jiayisunx changed the title [Inductor] Increase multiplier to 3 for Inductor AMP FP16 benchmark c… [Inductor] Increase multiplier to 3 for Inductor AMP FP16 benchmark correctness check (#135932) Sep 18, 2024
@kit1980 kit1980 merged commit becdf8a into pytorch:release/2.5 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants