Skip to content

[22/N] Fix clang-tidy warnings in jit #135319

Closed
cyyever wants to merge 11 commits intopytorch:mainfrom
cyyever:jit_tidy_onnx
Closed

[22/N] Fix clang-tidy warnings in jit #135319
cyyever wants to merge 11 commits intopytorch:mainfrom
cyyever:jit_tidy_onnx

Conversation

@cyyever
Copy link
Copy Markdown
Collaborator

@cyyever cyyever commented Sep 6, 2024 •
edited
Loading

Follows #134537

@pytorch-bot pytorch-bot Bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Sep 6, 2024
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Sep 6, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135319

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit c9c87b7 with merge base 67c7924 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft September 6, 2024 06:19
@cyyever cyyever force-pushed the jit_tidy_onnx branch 3 times, most recently from 8df5d42 to 1387e06 Compare September 6, 2024 07:50
@cyyever cyyever marked this pull request as ready for review September 6, 2024 10:46
@cyyever cyyever added the topic: not user facing topic category label Sep 6, 2024
@cyyever cyyever marked this pull request as draft September 6, 2024 10:49
@cyyever cyyever changed the title Jit tidy onnx [22/N] Fix clang-tidy warnings in jit Sep 7, 2024
@cyyever cyyever requested a review from Skylion007 September 7, 2024 01:28
@cyyever cyyever marked this pull request as ready for review September 7, 2024 01:28
@cyyever cyyever added the module: onnx Related to torch.onnx label Sep 7, 2024
@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented Sep 8, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 8, 2024
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 8, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented Sep 8, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 8, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 8, 2024

Merge started

Your change will be merged while ignoring the following 3 checks: pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, linux.2xlarge), pull / linux-focal-py3.9-clang10 / test (crossref, 2, 2, linux.2xlarge), trunk / macos-py3-arm64 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 8, 2024

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented Sep 8, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 8, 2024

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 3, 3, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (crossref, 2, 2, linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the jit_tidy_onnx branch September 9, 2024 01:48
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@cyyever @Chao1Han
[22/N] Fix clang-tidy warnings in jit (pytorch#135319)
220a68a 
Follows pytorch#134537
Pull Request resolved: pytorch#135319
Approved by: https://github.com/titaiwangms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyyever @pytorchmergebot @titaiwangms @pytorchbot