Skip to content

[21/N] Fix clang-tidy warnings in jit #134537

Closed
cyyever wants to merge 3 commits intopytorch:mainfrom
cyyever:jit_tidy_2000
Closed

[21/N] Fix clang-tidy warnings in jit #134537
cyyever wants to merge 3 commits intopytorch:mainfrom
cyyever:jit_tidy_2000

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Aug 27, 2024

Follows #133399

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 27, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134537

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit e56cb99 with merge base 5877131 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Aug 27, 2024
@cyyever cyyever changed the title Jit tidy 2000 [21/N] Fix clang-tidy warnings in jit Aug 27, 2024
@albanD albanD requested a review from swolchok August 27, 2024 14:44
@albanD albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 27, 2024
@albanD
Copy link
Collaborator

albanD commented Aug 27, 2024

No one is really maintaining this code. Adding @swolchok as reviewer as the last one touching these files

@cyyever
Copy link
Collaborator Author

cyyever commented Aug 28, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 28, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator Author

cyyever commented Aug 28, 2024

@pytorchbot merge -f "CI pending"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the jit_tidy_2000 branch August 28, 2024 03:25
pytorchmergebot pushed a commit that referenced this pull request Sep 8, 2024
pytorchmergebot pushed a commit that referenced this pull request Sep 19, 2024
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: jit release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants