Skip to content

[Reland] [Torchgen] Pass mutable to cpp.valuetype_type#134549

Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:torchgen_reland
Closed

[Reland] [Torchgen] Pass mutable to cpp.valuetype_type#134549
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:torchgen_reland

Conversation

@cyyever
Copy link
Copy Markdown
Collaborator

@cyyever cyyever commented Aug 27, 2024 •
edited
Loading

Reland of #121415

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Aug 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134549

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 763d8a7 with merge base 2ee201a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label Aug 27, 2024
@cyyever cyyever marked this pull request as draft August 27, 2024 03:52
@cyyever cyyever changed the title Pass mutable to cpp.valuetype_type [Torchgen]Pass mutable to cpp.valuetype_type Aug 30, 2024
@cyyever cyyever changed the title [Torchgen]Pass mutable to cpp.valuetype_type [Reland] [Torchgen] Pass mutable to cpp.valuetype_type Aug 30, 2024
@cyyever cyyever requested a review from ezyang August 30, 2024 01:00
@cyyever cyyever marked this pull request as ready for review August 30, 2024 01:00
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 30, 2024
ezyang
ezyang approved these changes Sep 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suuuure why not

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Sep 1, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 1, 2024
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 1, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 1, 2024

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented Sep 1, 2024

@pytorchbot merge -i

@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented Sep 1, 2024

@pytorchbot merge -f "Pending jobs"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 1, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the torchgen_reland branch September 1, 2024 15:16
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@cyyever @Chao1Han
[Reland] [Torchgen] Pass mutable to cpp.valuetype_type (pytorch#134549)
7207ff8 
Reland of pytorch#121415

Pull Request resolved: pytorch#134549
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @ezyang @pytorchmergebot @pytorchbot @janeyx99