[TorchGen] Add mutable parameter to valuetype_type function in api/cpp.py by cyyever · Pull Request #121415 · pytorch/pytorch

cyyever · 2024-03-07T15:00:29Z

This PR is a follow-up of #120076, it moves std::optional detection logic into valuetype_type of api/cpp.py by adding the mutable parameter, which facilitates future value type changes.

pytorch-bot · 2024-03-07T15:00:34Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121415

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit abd046b with merge base 476585b ():

NEW FAILURE - The following job has failed:

Check Labels (gh)

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / linux-focal-py3_8-clang9-xla / test (xla, 1, 1, linux.12xlarge) (gh)
Process completed with exit code 128.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet

PR title does not seem to match the change you are trying to make: it's not about std::optional, but rather about mutability of arguments, isn't it?

cyyever · 2024-03-07T15:33:34Z

PR title does not seem to match the change you are trying to make: it's not about std::optional, but rather about mutability of arguments, isn't it?

Sorry, I split the old PR into two parts, now the title is changed.

ezyang

okey dokey

ezyang · 2024-03-12T04:07:21Z

@pytorchbot merge -r

pytorchmergebot · 2024-03-12T04:09:05Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-03-12T04:09:09Z

Successfully rebased const_symint onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout const_symint && git pull --rebase)

pytorchmergebot · 2024-03-12T04:10:23Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-03-12T04:15:58Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / build

Details for Dev Infra team

Raised by workflow job

cyyever · 2024-03-12T06:14:25Z

@ezyang Thank you, but it can't be merged until #120076 is relanded.

cyyever · 2024-03-22T14:26:15Z

@pytorchbot rebase

pytorchmergebot · 2024-03-22T14:27:48Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-03-22T14:27:54Z

Successfully rebased const_symint onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout const_symint && git pull --rebase)

ezyang · 2024-03-24T03:28:46Z

@pytorchbot merge

pytorchmergebot · 2024-03-24T03:30:34Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

ezyang · 2024-03-25T20:12:59Z

@pytorchbot revert -c weird -m "I think this needs to be reverted to after #120076 revert"

pytorchmergebot · 2024-03-25T20:14:36Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-03-25T20:14:44Z

@cyyever your PR has been successfully reverted.

…n api/cpp.py (#121415)" This reverts commit c1fe09d. Reverted #121415 on behalf of https://github.com/ezyang due to I think this needs to be reverted to after #120076 revert ([comment](#121415 (comment)))

…n api/cpp.py (#121415)" This reverts commit c1fe09d. [ghstack-poisoned]

…p.py (#121415) This PR is a follow-up of #120076, it moves std::optional<Generator> detection logic into ```valuetype_type``` of api/cpp.py by adding the mutable parameter, which facilitates future value type changes. Pull Request resolved: #121415 Approved by: https://github.com/ezyang

…n api/cpp.py (#121415)" This reverts commit c1fe09d. Reverted #121415 on behalf of https://github.com/ezyang due to I think this needs to be reverted to after #120076 revert ([comment](#121415 (comment)))

github-actions · 2024-05-24T23:34:07Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Reland of #121415 Pull Request resolved: #134549 Approved by: https://github.com/ezyang

Reland of pytorch#121415 Pull Request resolved: pytorch#134549 Approved by: https://github.com/ezyang

pytorch-bot Bot added the topic: not user facing topic category label Mar 7, 2024

cyyever marked this pull request as draft March 7, 2024 15:00

pytorchbot added the open source label Mar 7, 2024

cyyever changed the title ~~Const symint~~ Use std::optional in torchgen Mar 7, 2024

cyyever force-pushed the const_symint branch from dbc052a to 358d5fd Compare March 7, 2024 15:13

cyyever marked this pull request as ready for review March 7, 2024 15:16

cyyever requested review from ezyang and malfet March 7, 2024 15:16

malfet requested changes Mar 7, 2024

View reviewed changes

cyyever changed the title ~~Use std::optional in torchgen~~ Pass mutable to cpp.valuetype_type Mar 7, 2024

cyyever changed the title ~~Pass mutable to cpp.valuetype_type~~ [TorchGen] Add mutable parameter to valuetype_type function Mar 7, 2024

cyyever requested a review from malfet March 7, 2024 15:44

cyyever changed the title ~~[TorchGen] Add mutable parameter to valuetype_type function~~ [TorchGen] Add mutable parameter to valuetype_type function in api/cpp.py Mar 7, 2024

mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 8, 2024

ezyang approved these changes Mar 12, 2024

View reviewed changes

pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 12, 2024

pytorchmergebot force-pushed the const_symint branch from 358d5fd to b1b1b84 Compare March 12, 2024 04:09

pytorchmergebot added the merging label Mar 12, 2024

pytorchmergebot removed the merging label Mar 12, 2024

pytorchmergebot force-pushed the const_symint branch from b1b1b84 to 27c05f7 Compare March 22, 2024 14:27

cyyever force-pushed the const_symint branch from 27c05f7 to 1dbb2fa Compare March 22, 2024 14:38

Pass mutable to cpp.valuetype_type

abd046b

cyyever force-pushed the const_symint branch from 1dbb2fa to abd046b Compare March 24, 2024 03:10

pytorchmergebot added the merging label Mar 24, 2024

pytorchmergebot added the Merged label Mar 24, 2024

pytorchmergebot closed this in c1fe09d Mar 24, 2024

pytorchmergebot removed the merging label Mar 24, 2024

pytorchmergebot added the Reverted label Mar 25, 2024

pytorchmergebot reopened this Mar 25, 2024

ezyang added a commit that referenced this pull request Mar 25, 2024

Revert "[TorchGen] Add mutable parameter to valuetype_type function i…

d423f99

…n api/cpp.py (#121415)" This reverts commit c1fe09d. [ghstack-poisoned]

github-actions Bot added the Stale label May 24, 2024

github-actions Bot closed this Jun 24, 2024

cyyever mentioned this pull request Aug 30, 2024

[Reland] [Torchgen] Pass mutable to cpp.valuetype_type #134549

Closed

pytorchmergebot pushed a commit that referenced this pull request Sep 1, 2024

[Reland] [Torchgen] Pass mutable to cpp.valuetype_type (#134549)

1595e75

Reland of #121415 Pull Request resolved: #134549 Approved by: https://github.com/ezyang

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024

[Reland] [Torchgen] Pass mutable to cpp.valuetype_type (pytorch#134549)

7207ff8

Reland of pytorch#121415 Pull Request resolved: pytorch#134549 Approved by: https://github.com/ezyang

cyyever deleted the const_symint branch December 9, 2024 15:28

Conversation

cyyever commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121415

❌ 1 New Failure, 1 Unrelated Failure

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

cyyever commented Mar 7, 2024

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

ezyang commented Mar 12, 2024

Uh oh!

pytorchmergebot commented Mar 12, 2024

Uh oh!

pytorchmergebot commented Mar 12, 2024

Uh oh!

pytorchmergebot commented Mar 12, 2024

Merge started

Uh oh!

pytorchmergebot commented Mar 12, 2024

Merge failed

Uh oh!

cyyever commented Mar 12, 2024

Uh oh!

cyyever commented Mar 22, 2024

Uh oh!

pytorchmergebot commented Mar 22, 2024

Uh oh!

pytorchmergebot commented Mar 22, 2024

Uh oh!

ezyang commented Mar 24, 2024

Uh oh!

pytorchmergebot commented Mar 24, 2024

Merge started

Uh oh!

ezyang commented Mar 25, 2024

Uh oh!

pytorchmergebot commented Mar 25, 2024

Uh oh!

pytorchmergebot commented Mar 25, 2024

Uh oh!

github-actions Bot commented May 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cyyever commented Mar 7, 2024 •

edited

Loading

pytorch-bot Bot commented Mar 7, 2024 •

edited

Loading