Revert "add keyword out for autograd function Concat to match torch.cat"#1340
Merged
Revert "add keyword out for autograd function Concat to match torch.cat"#1340
out for autograd function Concat to match torch.cat"#1340Conversation
Collaborator
|
oh, whoops i guess. |
Member
|
We still need to fix torch.stack() on variables: Line 56 in 24d92b5 |
eqy
pushed a commit
to eqy/pytorch
that referenced
this pull request
Jan 20, 2022
Fixing a few smaller issues here and there: Exposing python API to switch single node fusion; Exposing python API to switch horizontal fusion (Needed to avoid PW scheduler failure on fusion with outputs of different shapes/ranks); Adding shape expression short-cut support for native_dropout (Bug reported by AOTAutograd); Fixing device check to avoid fusion of node with inputs on different device. Long term we should have supported this, but disabling it for now to avoid assert. (e.g. scalar cpu tensor can be operated on cuda tensors, feature from TensorIterator).
hubertlu-tw
pushed a commit
to hubertlu-tw/pytorch
that referenced
this pull request
Nov 1, 2022
Peer memory halo exchange
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1336.
Variables should never have
outarguments.