Skip to content

add keyword out for autograd function Concat to match torch.cat#1336

Merged
soumith merged 1 commit intopytorch:masterfrom
chenyuntc:master
Apr 23, 2017
Merged

add keyword out for autograd function Concat to match torch.cat#1336
soumith merged 1 commit intopytorch:masterfrom
chenyuntc:master

Conversation

@chenyuntc
Copy link
Copy Markdown
Contributor

torch.cat has been improved by pull request 1323, while autograd function hasn't, so sometimes it raises error(torch.stack for Variable).

see discuss in forum

@soumith soumith merged commit 71b9dea into pytorch:master Apr 23, 2017
@soumith
Copy link
Copy Markdown
Collaborator

soumith commented Apr 23, 2017

thanks!

@neverfox
Copy link
Copy Markdown

neverfox commented May 9, 2017

Built clean from source today and I still get the error on stack that cat() got an unexpected keyword argument 'out'.

@fmassa
Copy link
Copy Markdown
Member

fmassa commented May 9, 2017

@neverfox this is expected, see #1340

eqy pushed a commit to eqy/pytorch that referenced this pull request Jan 20, 2022
rraminen pushed a commit to rraminen/pytorch that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants