Add zero padding module#1326
Merged
soumith merged 8 commits intopytorch:masterfrom Apr 25, 2017
andrewgiessel:add-zero-padding-module
Merged
Add zero padding module#1326soumith merged 8 commits intopytorch:masterfrom andrewgiessel:add-zero-padding-module
soumith merged 8 commits intopytorch:masterfrom
andrewgiessel:add-zero-padding-module
Conversation
Member
|
Why restrict it to zero padding, and not just make a ConstantPad2d a module as well? |
Contributor
Author
|
Sure, I can do that good idea
…On Sat, Apr 22, 2017 at 13:20 Francisco Massa ***@***.***> wrote:
Why restrict it to zero padding, and not just make a ConstantPad2d a
module as well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1326 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABG3Jaw4Ask70MJZC6Rg4AoPuREH2jwWks5ryjb0gaJpZM4NE6gA>
.
|
Including test and __init__ import. Not sure if the way I imported the function (to avoid namespace clobber) is the best. all of functional, but not sure if tha
Contributor
Author
|
Added Also the tests are failing for some import reason, even after @soumith's commit. I assume I need to add the import someplace else, but I'm not sure where. Edit: oh, I think it's simply because these classes aren't in all. |
Contributor
Author
soumith
approved these changes
Apr 25, 2017
Collaborator
|
thanks Andrew! |
Member
|
Hi, thanks for the PR! |
Collaborator
|
had a discussion with @apaszke we think it's best to deprecate all padding layers to F.pad and nn.Pad and all crop layers to F.crop and nn.Crop so please expect this pr to be deprecated soon. |
Contributor
Author
|
@soumith sure, that seems like a good idea. Can I do anything to help? |
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
Sep 23, 2024
- Add missing common_utils.sh - Update the install vision part - Move to amdgpu rhel 9.3 builds - Update to pick python from conda path - Add a missing package - Add ROCM_PATH and magma - Updated repo radeon path
jagadish-amd
pushed a commit
to jagadish-amd/pytorch
that referenced
this pull request
Jan 29, 2025
==================================================== [SOW MS3] Centos stream9 PyTorch image support (pytorch#1090) * changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com> Updated to latest conda for CentOS stream 9 [CS9] Updates to CentOS stream 9 build (pytorch#1326) - Add missing common_utils.sh - Update the install vision part - Move to amdgpu rhel 9.3 builds - Update to pick python from conda path - Add a missing package - Add ROCM_PATH and magma - Updated repo radeon path
jagadish-amd
pushed a commit
to jagadish-amd/pytorch
that referenced
this pull request
May 15, 2025
==================================================== [SOW MS3] Centos stream9 PyTorch image support (pytorch#1090) * changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com> Updated to latest conda for CentOS stream 9 [CS9] Updates to CentOS stream 9 build (pytorch#1326) - Add missing common_utils.sh - Update the install vision part - Move to amdgpu rhel 9.3 builds - Update to pick python from conda path - Add a missing package - Add ROCM_PATH and magma - Updated repo radeon path (cherry picked from commit 51ce1cc) [rocm6.4_internal_testing] Update missing changes for CentOS9 (pytorch#1813) To fix, https://ontrack-internal.amd.com/browse/SWDEV-505385 and https://ontrack-internal.amd.com/browse/SWDEV-507301 (cherry picked from commit 956c145) delete .ci/docker/common/install_db.sh
scotts
added a commit
to scotts/pytorch
that referenced
this pull request
Mar 31, 2026
8b42d4c..185fe9c includes the following commits: 185fe9c Expose occupany limiting factors (pytorch#1330) 0c8ede0 remove the rocprofiler early exit hack (pytorch#1329) 4826a43 Remove duplicate test ignore (pytorch#1328) 37fada9 Ensure that async doesn't loop while sync is active (pytorch#1327) 628e1d0 Add host_name to OSS Kineto trace metadata via gethostname() (pytorch#1323) 9d7373b Revert D97166802 (pytorch#1326) 3a61657 Fix Lingering INT32 Overflow (pytorch#1324) 50a0085 Re-enabled some hardcoded tests (pytorch#1321) e19dd92 Expose occupany limiting factors (pytorch#1322) Authored with Claude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1324
Since
F.padsimply wrapsConstantPad2d, I usedConstantPad2dinstead.