Add back zero fill for ger#1090
Merged
apaszke merged 1 commit intopytorch:masterfrom Mar 24, 2017
Merged
Conversation
Ger does not have beta argument, so has to be zero-filled.
Contributor
|
Isn't this beta? |
Collaborator
Author
|
Should be, but cublas call http://docs.nvidia.com/cuda/cublas/#cublas-lt-t-gt-ger that it actually maps to does not have beta parameter. |
Contributor
|
Ugh, we should add a check to THC that raises an error if beta is not 1 then! |
apaszke
approved these changes
Mar 24, 2017
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Nov 5, 2021
Rework indexing to be more robust in rfactors resulting from view operations.
syed-ahmed
pushed a commit
to syed-ahmed/pytorch
that referenced
this pull request
Sep 22, 2022
* Add python 3.11.0b1 to docker image
dllehr-amd
pushed a commit
to dllehr-amd/pytorch
that referenced
this pull request
Sep 27, 2022
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
rraminen
added a commit
to rraminen/pytorch
that referenced
this pull request
Sep 29, 2022
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
dllehr-amd
pushed a commit
to dllehr-amd/pytorch
that referenced
this pull request
Dec 15, 2022
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
dllehr-amd
pushed a commit
to dllehr-amd/pytorch
that referenced
this pull request
Jan 24, 2023
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
dllehr-amd
pushed a commit
to dllehr-amd/pytorch
that referenced
this pull request
Jan 24, 2023
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
jaglinux
pushed a commit
to jaglinux/pytorch
that referenced
this pull request
Feb 8, 2023
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
jaglinux
pushed a commit
to jaglinux/pytorch
that referenced
this pull request
Feb 8, 2023
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
jaglinux
pushed a commit
to jaglinux/pytorch
that referenced
this pull request
Feb 22, 2023
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
jaglinux
pushed a commit
to jaglinux/pytorch
that referenced
this pull request
Feb 22, 2023
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
dllehr-amd
pushed a commit
to dllehr-amd/pytorch
that referenced
this pull request
Apr 5, 2023
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
rraminen
added a commit
to rraminen/pytorch
that referenced
this pull request
Oct 11, 2023
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
Sep 23, 2024
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
jagadish-amd
pushed a commit
to jagadish-amd/pytorch
that referenced
this pull request
Jan 29, 2025
==================================================== [SOW MS3] Centos stream9 PyTorch image support (pytorch#1090) * changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com> Updated to latest conda for CentOS stream 9 [CS9] Updates to CentOS stream 9 build (pytorch#1326) - Add missing common_utils.sh - Update the install vision part - Move to amdgpu rhel 9.3 builds - Update to pick python from conda path - Add a missing package - Add ROCM_PATH and magma - Updated repo radeon path
jagadish-amd
pushed a commit
to jagadish-amd/pytorch
that referenced
this pull request
May 15, 2025
==================================================== [SOW MS3] Centos stream9 PyTorch image support (pytorch#1090) * changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com> Updated to latest conda for CentOS stream 9 [CS9] Updates to CentOS stream 9 build (pytorch#1326) - Add missing common_utils.sh - Update the install vision part - Move to amdgpu rhel 9.3 builds - Update to pick python from conda path - Add a missing package - Add ROCM_PATH and magma - Updated repo radeon path (cherry picked from commit 51ce1cc) [rocm6.4_internal_testing] Update missing changes for CentOS9 (pytorch#1813) To fix, https://ontrack-internal.amd.com/browse/SWDEV-505385 and https://ontrack-internal.amd.com/browse/SWDEV-507301 (cherry picked from commit 956c145) delete .ci/docker/common/install_db.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ger does not have beta argument, so has to be zero-filled.