[ONNX] Rename _internal/exporter to _exporter_legacy#132429
Closed
justinchuby wants to merge 3 commits intogh/justinchuby/95/basefrom
Closed
[ONNX] Rename _internal/exporter to _exporter_legacy#132429justinchuby wants to merge 3 commits intogh/justinchuby/95/basefrom
justinchuby wants to merge 3 commits intogh/justinchuby/95/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132429
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8d49aa1 with merge base 0c49170 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The next PR will be creating an `exporter` directory to house logic from `torch-onnx` [ghstack-poisoned]
titaiwangms
approved these changes
Aug 2, 2024
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
justinchuby
added a commit
to justinchuby/pytorch
that referenced
this pull request
Aug 3, 2024
ghstack-source-id: 8f07572 Pull Request resolved: pytorch#132429
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Aug 6, 2024
Summary: The next PR will be creating an `exporter` directory to house logic from `torch-onnx` X-link: pytorch/pytorch#132429 Approved by: https://github.com/titaiwangms Reviewed By: PaliC Differential Revision: D60781226 fbshipit-source-id: c73e961c3cf7c752ab3fa7fc7912013355244339
mindest
added a commit
to microsoft/onnxruntime
that referenced
this pull request
Aug 21, 2024
### Description Fix `Orttraining Linux Lazy Tensor CI Pipeline` - Remove unused import of `torch.onnx._internal.exporter`, whose path is changed in newer torch (pytorch/pytorch#132429). - Move import of `register_custom_op_symbolic` from `torch.onnx` into local function, which causes circular import when running `import torch.onnx` (at least in the CI environment).
tianleiwu
pushed a commit
to microsoft/onnxruntime
that referenced
this pull request
Aug 29, 2024
### Description Fix `Orttraining Linux Lazy Tensor CI Pipeline` - Remove unused import of `torch.onnx._internal.exporter`, whose path is changed in newer torch (pytorch/pytorch#132429). - Move import of `register_custom_op_symbolic` from `torch.onnx` into local function, which causes circular import when running `import torch.onnx` (at least in the CI environment).
rohan11235813
pushed a commit
to quadric-io/onnxruntime
that referenced
this pull request
Aug 19, 2025
### Description Fix `Orttraining Linux Lazy Tensor CI Pipeline` - Remove unused import of `torch.onnx._internal.exporter`, whose path is changed in newer torch (pytorch/pytorch#132429). - Move import of `register_custom_op_symbolic` from `torch.onnx` into local function, which causes circular import when running `import torch.onnx` (at least in the CI environment).
rohan11235813
pushed a commit
to quadric-io/onnxruntime
that referenced
this pull request
Sep 15, 2025
### Description Fix `Orttraining Linux Lazy Tensor CI Pipeline` - Remove unused import of `torch.onnx._internal.exporter`, whose path is changed in newer torch (pytorch/pytorch#132429). - Move import of `register_custom_op_symbolic` from `torch.onnx` into local function, which causes circular import when running `import torch.onnx` (at least in the CI environment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The next PR will be creating an
exporterdirectory to house logic fromtorch-onnxcc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames