Skip to content

[ONNX] New export logic leveraging ExportedProgram and ONNX IR#132530

Closed
justinchuby wants to merge 19 commits intogh/justinchuby/96/basefrom
gh/justinchuby/96/head
Closed

[ONNX] New export logic leveraging ExportedProgram and ONNX IR#132530
justinchuby wants to merge 19 commits intogh/justinchuby/96/basefrom
gh/justinchuby/96/head

Conversation

@justinchuby
Copy link
Copy Markdown
Collaborator

@justinchuby justinchuby commented Aug 2, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

1/n PR to

  • Move code from torch-onnx from commit justinchuby/torch-onnx@395495e into torch.onnx and fixes imports.
  • Integrate the new export logic with the torch.onnx.export API and include basic set of tests.
  • Refactor the API for the change.
  • Improve documentation.

Next PRs will be more tests and docs.

Fix #129277

@justinchuby
Update
002d619 
[ghstack-poisoned]
@justinchuby justinchuby mentioned this pull request Aug 2, 2024
Closed
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Aug 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132530

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 29 Pending, 3 Unrelated Failures

As of commit d564126 with merge base 15b5a0b (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Aug 2, 2024
@justinchuby justinchuby requested a review from xadupre August 2, 2024 17:51
@justinchuby
Update
8607f50 
[ghstack-poisoned]
@justinchuby justinchuby requested a review from albanD as a code owner August 2, 2024 18:29
@justinchuby

This comment was marked as resolved.

Sign in to view
titaiwangms
titaiwangms reviewed Aug 3, 2024
View reviewed changes
Comment thread test/test_public_bindings.py Outdated
@justinchuby
Update
2bdb47f 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 3, 2024
@justinchuby
[ONNX] Migrate torch-onnx v0.1.6
fd0a5ef 
ghstack-source-id: f52656d
Pull Request resolved: #132530
@justinchuby justinchuby mentioned this pull request Aug 5, 2024
Closed
@justinchuby
Update
35fe323 
[ghstack-poisoned]
@justinchuby
Update
8626271 
[ghstack-poisoned]
@justinchuby
Update
5a67774 
[ghstack-poisoned]
@justinchuby
Update
dd8a7e7 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 6, 2024
@justinchuby
[ONNX] Migrate torch-onnx v0.1.6
302a6f9 
ghstack-source-id: 5c370d8
Pull Request resolved: #132530
@justinchuby justinchuby mentioned this pull request Aug 9, 2024
Closed
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Aug 9, 2024
@justinchuby
[ONNX] Migrate torch-onnx v0.1.6
ded276f 
ghstack-source-id: 5c370d8
Pull Request resolved: pytorch#132530
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 19, 2024

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Aug 19, 2024
@pytorchmergebot
Revert "[ONNX] New export logic leveraging ExportedProgram and ONNX IR (
8d40458 
#132530)"

This reverts commit 5fab35d.

Reverted #132530 on behalf of https://github.com/ZainRizvi due to Sorry but it seems like Dr. CI incorrectly flagged the [pull / linux-docs / build-docs-python-false](https://hud.pytorch.org/pr/pytorch/pytorch/132530#28918577682) failure as being flaky. The job started failing consistently on CI once your PR was merged. [GH job link](https://github.com/pytorch/pytorch/actions/runs/10454830880/job/28949386844) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/5fab35d77c7d1db7dbb9d5c516254a510b4f4f64) ([comment](#132530 (comment)))
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 19, 2024

@justinchuby your PR has been successfully reverted.

@justinchuby

This comment was marked as resolved.

Sign in to view
@justinchuby
Copy link
Copy Markdown
Collaborator Author

justinchuby commented Aug 20, 2024

I think I know what is going on. I am going to rebase after #133825

@justinchuby
Copy link
Copy Markdown
Collaborator Author

justinchuby commented Aug 20, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 20, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 20, 2024

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/10479306647

@justinchuby
Update on "[ONNX] New export logic leveraging ExportedProgram and ONN…
d564126 
…X IR"


1/n PR to

- Move code from torch-onnx from commit justinchuby/torch-onnx@395495e into torch.onnx and fixes imports.
- Integrate the new export logic with the torch.onnx.export API and include basic set of tests.
- Refactor the API for the change.
- Improve documentation.

Next PRs will be more tests and docs.

Fix #129277

[ghstack-poisoned]
@justinchuby
Update on "[ONNX] New export logic leveraging ExportedProgram and ONN…
052e834 
…X IR"


1/n PR to

- Move code from torch-onnx from commit justinchuby/torch-onnx@395495e into torch.onnx and fixes imports.
- Integrate the new export logic with the torch.onnx.export API and include basic set of tests.
- Refactor the API for the change.
- Improve documentation.

Next PRs will be more tests and docs.

Fix #129277

[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 20, 2024
@justinchuby
[ONNX] Migrate torch-onnx v0.1.6
2d7efd5 
ghstack-source-id: 727d159
Pull Request resolved: #132530
@justinchuby
Copy link
Copy Markdown
Collaborator Author

justinchuby commented Aug 21, 2024

@pytorchbot merge -f "Rocm tests unrelated."

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 21, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

titaiwangms
titaiwangms reviewed Sep 6, 2024
View reviewed changes
Comment thread torch/onnx/_internal/exporter/_building.py
@github-actions github-actions Bot deleted the gh/justinchuby/96/head branch October 7, 2024 02:07
@justinchuby justinchuby mentioned this pull request Feb 5, 2025
Closed
@justinchuby justinchuby mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@malfet malfet malfet approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

@wschin wschin Awaiting requested review from wschin

@xadupre xadupre Awaiting requested review from xadupre

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes Reverted suppress-api-compatibility-check Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@justinchuby @pytorchmergebot @ZainRizvi @malfet @titaiwangms @pytorchbot