Conversation
Adding -fexceptions to both torch and pytorch C/C++ builds fixes tests not passing. Closes pytorch#1297
|
@pytorchbot test this please |
1 similar comment
|
@pytorchbot test this please |
|
The PR breaks CUDA builds (nvcc doesn't support |
|
Right now I can't do a CUDA build. But the main idea should be just not to pass |
|
from what i get, you only need |
|
@soumith I tested giving up the changes in build_all.sh and unfortunately that does not work. We have to pass the flag to both C and C++ builds. |
|
@soumith The flag is only needed for files compiled with the C compiler, so it's needed for |
|
@pytorchbot test this please |
NVCC does not support it.
| cd build/$1 | ||
| BUILD_C_FLAGS='' | ||
| eval 'case '$1' in | ||
| '${NVCC_TARGETS//" "/" | "}') BUILD_C_FLAGS=$C_FLAGS;; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@brunoalr i presume you didn't get time after that to work on this. I'm closing the PR for now, it's quite stale. |
New commits included: - 0c52fa6 Fix compilation of XPU part of kineto (pytorch#1292) - f882254 Add MTIA_COUNTERS ActivityType and counter event output support (pytorch#1303) - c6c84d0 Use whole data from PTI activity record (pytorch#1278) - bb1e194 Add additionalLoggerCollector mechanism to ActivityProfilerController (pytorch#1290) - 041c3e1 Disable test_record_function_fast (pytorch#1309) - e8956c4 Integrate PyTorch's disabled tests mechanism into CI (pytorch#1311) - 7d860f2 Fix unit test (pytorch#1305) - 058386f Add Mac CPU workflow (pytorch#1304) - c12ddc2 refactor CuptiCbidRegistry member function names (pytorch#1301) - 3b5cdca Add comms Id to trace output JSON (pytorch#1300) Authored with Claude.
New commits included: - 0c52fa6 Fix compilation of XPU part of kineto (#1292) - f882254 Add MTIA_COUNTERS ActivityType and counter event output support (#1303) - c6c84d0 Use whole data from PTI activity record (#1278) - bb1e194 Add additionalLoggerCollector mechanism to ActivityProfilerController (#1290) - 041c3e1 Disable test_record_function_fast (#1309) - e8956c4 Integrate PyTorch's disabled tests mechanism into CI (#1311) - 7d860f2 Fix unit test (#1305) - 058386f Add Mac CPU workflow (#1304) - c12ddc2 refactor CuptiCbidRegistry member function names (#1301) - 3b5cdca Add comms Id to trace output JSON (#1300) Authored with Claude. Pull Request resolved: #177753 Approved by: https://github.com/ryanzhang22
Adding -fexceptions to both torch and pytorch C/C++ builds fixes tests
not passing in ppc64le and aarch64.
See https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_exceptions.html
Closes #1297