Fix argument typo in pad_packed_sequence() docstring#1300
Merged
soumith merged 1 commit intopytorch:masterfrom Apr 19, 2017
Merged
Fix argument typo in pad_packed_sequence() docstring#1300soumith merged 1 commit intopytorch:masterfrom
soumith merged 1 commit intopytorch:masterfrom
Conversation
Collaborator
|
thanks! |
eqy
pushed a commit
to eqy/pytorch
that referenced
this pull request
Jan 20, 2022
Currently, predicates are generated on reference tensors, but that can cause problems as discussed as references may not have matching domains for consumer roots when references are generated from post-view tensors. This PR changes the predication method so that it basically follows the same approach as consumer indexing where reference indices are propagated to consumer domains, followed by consumer indexing.
hubertlu-tw
pushed a commit
to hubertlu-tw/pytorch
that referenced
this pull request
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argument name incorrect in docstring comment ("batch_size" rather than actual argument "batch_first").