Pin `sympy >= 1.13.0` by XuehaiPan · Pull Request #130895 · pytorch/pytorch

XuehaiPan · 2024-07-17T03:05:45Z

Stack from ghstack (oldest at bottom):

The opposite of #130836. Pin sympy >= 1.13.0 for Python >= 3.9 and sympy == 1.12.1 for Python 3.8.

Pin sympy < 1.13.0a0 #130836

See the PR description of #130836 for more details.

sympy 1.13.0 introduces some breaking changes which break our tests. More specifically:

Ref Backwards compatibility breaks and deprecations

BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x2.0 != x2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. (#25614 by @smichr)

sympy >= 1.13.0 is required to enable Python 3.13 support. This should be part of #130689.

[Not to be merged] Update to compile and run test_torch with 3.13t #130689

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @seemethere @malfet @pytorch/pytorch-dev-infra @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang

[ghstack-poisoned]

pytorch-bot · 2024-07-17T03:05:48Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130895

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit ef9ca93 with merge base 3c622fb ():

CANCELLED JOB - The following job was cancelled. Please retry:

Mac MPS / macos-py3-arm64-mps / test (mps, 1, 1, macos-m2-14) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

XuehaiPan · 2024-07-17T04:49:57Z

~~Found another bug for sympy:~~

In [1]: import sympy

In [2]: f = sympy.Float(0.0)

In [3]: abs(f)
Out[3]: 0

In [4]: f == abs(f)
Out[4]: False

[ghstack-poisoned]

ghstack-source-id: ac1dd3b Pull Request resolved: #130895

[ghstack-poisoned]

XuehaiPan · 2024-07-20T00:57:20Z

@pytorchbot merge -i

pytorchmergebot · 2024-07-20T00:59:12Z

Merge started

Your change will be merged while ignoring the following 1 checks: Mac MPS / macos-py3-arm64-mps / test (mps, 1, 1, macos-m2-14)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes #130155 Pull Request resolved: #130139 Approved by: https://github.com/zou3519 ghstack dependencies: #130895

@smichr

------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang

@smichr

------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang

Pull Request resolved: #130144 Approved by: https://github.com/zou3519 ghstack dependencies: #130895, #130139

@smichr

------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang

0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes pytorch#130155 Pull Request resolved: pytorch#130139 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895

Pull Request resolved: pytorch#130144 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895, pytorch#130139

albanD · 2024-07-22T14:16:04Z

@XuehaiPan this is actually breaking nighlty builds on conda because only sympy up to 1.12.0 seems to be available there: https://anaconda.org/anaconda/sympy/files
Do you know if it is expected?

XuehaiPan · 2024-07-22T18:09:12Z

on conda because only sympy up to 1.12.0 seems to be available there: anaconda.org/anaconda/sympy/files
Do you know if it is expected?

@albanD We may need to open an issue here (https://github.com/ContinuumIO/anaconda-issues/issues?q=label%3Apackage_request+) to request a version update.

The short-term solution is to loosen the constraint to sympy >= 1.12.0 (1.12 is required for function equal_valued).

Fixing nightly after #130895 Pull Request resolved: #131355 Approved by: https://github.com/atalman

…131355) Fixing nightly after pytorch#130895 Pull Request resolved: pytorch#131355 Approved by: https://github.com/atalman

@smichr

------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang

0.12.0 Major Updates: - Add context manager to temporarily set the dictionary sorting mode - Add accessor APIs - Use `stable` tag for `pybind11` for Python 3.13 support - Fix potential segmentation fault for pickling support 0.12.1 Updates: - Fix warning regression during import when launch with strict warning filters Closes pytorch#130155 Pull Request resolved: pytorch#130139 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895

Pull Request resolved: pytorch#130144 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#130895, pytorch#130139

…131355) Fixing nightly after pytorch#130895 Pull Request resolved: pytorch#131355 Approved by: https://github.com/atalman

adamjstewart · 2025-02-08T20:25:47Z

Is there anything we can do to relax this version pin? Would make compatibility in large environments easier.

Update

1529be7

[ghstack-poisoned]

XuehaiPan requested a review from a team as a code owner July 17, 2024 03:05

pytorch-bot Bot added the topic: not user facing topic category label Jul 17, 2024

XuehaiPan added module: ci Related to continuous integration ciflow/trunk Trigger trunk jobs on your pull request release notes: releng release notes category ciflow/mps Run MPS tests (subset of trunk) ciflow/rocm Trigger "default" config CI on ROCm labels Jul 17, 2024

XuehaiPan marked this pull request as draft July 17, 2024 03:09

XuehaiPan requested review from albanD and ezyang July 17, 2024 03:09

XuehaiPan mentioned this pull request Jul 17, 2024

[Not to be merged] Update to compile and run test_torch with 3.13t #130689

Closed

9 tasks

pytorchbot added the open source label Jul 17, 2024

XuehaiPan mentioned this pull request Jul 17, 2024

Pin sympy < 1.13.0a0 #130836

Closed

Update

877936b

[ghstack-poisoned]

pytorch-bot Bot added ciflow/inductor module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor labels Jul 17, 2024

Update

3090f36

[ghstack-poisoned]

Update

3247464

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Jul 17, 2024

[POC] Pin sympy >= 1.13.0

9a4a8e9

ghstack-source-id: ac1dd3b Pull Request resolved: #130895

XuehaiPan marked this pull request as ready for review July 17, 2024 06:24

Update

45a4f0a

[ghstack-poisoned]

XuehaiPan mentioned this pull request Jul 16, 2024

[BE] bump optree version to 0.12.1 #130139

Closed

pytorchmergebot added the Merged label Jul 20, 2024

pytorchmergebot closed this in f0075c1 Jul 20, 2024

pytorchmergebot removed the merging label Jul 20, 2024

huydhn mentioned this pull request Jul 20, 2024

[executorch hash update] update the pinned executorch hash #130001

Closed

This was referenced Jul 20, 2024

[reland, 2.4] Pin sympy >= 1.13.0 for pip and sympy >= 1.12.0 for conda #131281

Closed

[v.2.4.0] Release Tracker #128436

Closed

pytorchmergebot pushed a commit that referenced this pull request Jul 21, 2024

[Easy][pytree] enable CXX pytree under torch::deploy (#130144)

1439bd3

Pull Request resolved: #130144 Approved by: https://github.com/zou3519 ghstack dependencies: #130895, #130139

albanD mentioned this pull request Jul 22, 2024

Only depend on sympy 1.12 for conda (no 3.13 there anyways) #131355

Closed

XilunWu reviewed Jul 22, 2024

View reviewed changes

Comment thread torch/utils/_sympy/functions.py

pytorchmergebot pushed a commit that referenced this pull request Jul 23, 2024

Only depend on sympy 1.12 for conda (no 3.13 there anyways) (#131355)

eb146b1

Fixing nightly after #130895 Pull Request resolved: #131355 Approved by: https://github.com/atalman

henrylhtsang mentioned this pull request Jul 31, 2024

[BE][typing] fix types in common pruning #132309

Closed

github-actions Bot deleted the gh/XuehaiPan/126/head branch August 23, 2024 01:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pin `sympy >= 1.13.0`#130895

Pin `sympy >= 1.13.0`#130895
XuehaiPan wants to merge 19 commits intogh/XuehaiPan/126/basefrom
gh/XuehaiPan/126/head

XuehaiPan commented Jul 17, 2024 •

edited

Loading

Uh oh!

pytorch-bot Bot commented Jul 17, 2024 •

edited

Loading

Uh oh!

XuehaiPan commented Jul 17, 2024 •

edited

Loading

Uh oh!

XuehaiPan commented Jul 20, 2024

Uh oh!

pytorchmergebot commented Jul 20, 2024

Uh oh!

albanD commented Jul 22, 2024

Uh oh!

XuehaiPan commented Jul 22, 2024

Uh oh!

Uh oh!

adamjstewart commented Feb 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

XuehaiPan commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130895

❌ 1 Cancelled Job

Uh oh!

XuehaiPan commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XuehaiPan commented Jul 20, 2024

Uh oh!

pytorchmergebot commented Jul 20, 2024

Merge started

Uh oh!

albanD commented Jul 22, 2024

Uh oh!

XuehaiPan commented Jul 22, 2024

Uh oh!

Uh oh!

adamjstewart commented Feb 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

XuehaiPan commented Jul 17, 2024 •

edited

Loading

pytorch-bot Bot commented Jul 17, 2024 •

edited

Loading

XuehaiPan commented Jul 17, 2024 •

edited

Loading