Pin `sympy < 1.13.0a0` by XuehaiPan · Pull Request #130836 · pytorch/pytorch

XuehaiPan · 2024-07-16T13:45:52Z

Stack from ghstack (oldest at bottom):

sympy 1.13.0 introduces some breaking changes which break our tests. More specifically:

Ref Backwards compatibility breaks and deprecations

BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x2.0 != x2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. (#25614 by @smichr)

With sympy 1.12.1:

In [1]: from torch.utils._sympy.functions import FloorDiv

In [2]: FloorDiv(1.0, 1.0)
Out[2]: (1.0//1.0)

$ PYTORCH_TEST_WITH_DYNAMO=1 python test/test_sympy_utils.py
.........................................................................................s....................................................................
----------------------------------------------------------------------
Ran 158 tests in 15.362s

OK (skipped=1)

With sympy 1.13.0:

In [1]: from torch.utils._sympy.functions import FloorDiv

In [2]: FloorDiv(1.0, 1.0)
RecursionError: maximum recursion depth exceeded

$ PYTORCH_TEST_WITH_DYNAMO=1 python test/test_sympy_utils.py
.........................................................................................s....EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE....................................................F..........
======================================================================
...

======================================================================
ERROR: test_binary_ref_fn_floordiv_dtype_float (__main__.TestValueRanges.test_binary_ref_fn_floordiv_dtype_float) (a=9223372036854775807., b=9223372036854775807.)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/PanXuehai/Projects/pytorch/test/test_sympy_utils.py", line 229, in test_binary_ref
    r = getattr(ValueRangeAnalysis, fn)(a, b)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/PanXuehai/Projects/pytorch/torch/utils/_sympy/value_ranges.py", line 564, in floordiv
    r = FloorDiv(x, y)
...
RecursionError: maximum recursion depth exceeded

======================================================================
FAIL: test_unary_ref_fn_square_dtype_float (__main__.TestValueRanges.test_unary_ref_fn_square_dtype_float) (v=0)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/PanXuehai/Projects/pytorch/test/test_sympy_utils.py", line 210, in test_unary_ref
    self.assertEqual(ref_r, r.lower)
  File "/Users/PanXuehai/Projects/pytorch/torch/testing/_internal/common_utils.py", line 3721, in assertEqual
    raise error_metas.pop()[0].to_error(
AssertionError: Object comparison failed: 0.0 != 0

----------------------------------------------------------------------
Ran 158 tests in 35.650s

FAILED (failures=1, errors=289, skipped=1)

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130836

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Cancelled Job, 2 Unrelated Failures

As of commit bf5b562 with merge base 67c6941 ():

NEW FAILURES - The following jobs have failed:

xpu / linux-jammy-xpu-py3.8 / test (default, 1, 4, linux.idc.xpu) (gh)
Action 'https://api.github.com/repos/pytorch/pytorch/tarball/d7a8e8f7c5a0a536cecf397561d161d8576e9574' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
xpu / linux-jammy-xpu-py3.8 / test (default, 2, 4, linux.idc.xpu) (gh)
Action 'https://api.github.com/repos/pytorch/pytorch/tarball/d7a8e8f7c5a0a536cecf397561d161d8576e9574' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
xpu / linux-jammy-xpu-py3.8 / test (default, 3, 4, linux.idc.xpu) (gh)
Action 'https://api.github.com/repos/pytorch/pytorch/tarball/d7a8e8f7c5a0a536cecf397561d161d8576e9574' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
xpu / linux-jammy-xpu-py3.8 / test (default, 4, 4, linux.idc.xpu) (gh)
Action 'https://api.github.com/repos/pytorch/pytorch/tarball/d7a8e8f7c5a0a536cecf397561d161d8576e9574' download has timed out. Error: The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.

CANCELLED JOB - The following job was cancelled. Please retry:

Mac MPS / macos-py3-arm64-mps / test (mps, 1, 1, macos-m2-14) (gh)

FLAKY - The following job failed but was likely due to flakiness present on trunk:

rocm / linux-focal-rocm6.1-py3.8 / test (default, 1, 6, linux.rocm.gpu.2) (gh) (similar failure)
'test/profiler/test_cpp_thread.py::CppThreadTest::test_with_enable_profiler_in_child_thread'

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Lint / lintrunner-noclang / linux-job (gh) (trunk failure)
>>> Lint for torch/_functorch/_aot_autograd/subclass_utils.py:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Skylion007 · 2024-07-16T13:48:44Z

I'm pretty sure pinning this version will block Python 3.13 support

XuehaiPan · 2024-07-16T13:55:56Z

I'm pretty sure pinning this version will block Python 3.13 support

I think we can upgrade the version after all the tests are fixed.

XuehaiPan · 2024-07-16T14:15:16Z

I'm also wondering why our CI does not capture this.

albanD · 2024-07-16T20:11:25Z

Ho yeah I was planning on pin sympy >= 1.13 in #130689 haha

What are the tests that need fixing for this? because the PR above that upgrades sympy does pass all CI.

ezyang · 2024-07-17T00:37:42Z

Yeah, I'd rather just take a PR that gets us working on 1.13

XuehaiPan · 2024-07-17T03:32:59Z

What are the tests that need fixing for this? because the PR above that upgrades sympy does pass all CI.

See CI result for #130895.

Yeah, I'd rather just take a PR that gets us working on 1.13

I will try that.

XuehaiPan · 2024-07-17T07:57:37Z

Closing this in favor of #130895.

Pin sympy >= 1.13.0 #130895

@smichr

------ The opposite of #130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - #130836 See the PR description of #130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of #130689. - #130689 Pull Request resolved: #130895 Approved by: https://github.com/ezyang

@smichr

------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang

@smichr

------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang

@smichr

------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang

ghstack-source-id: 864a00c Pull Request resolved: pytorch/pytorch#130836

@smichr

------ The opposite of pytorch#130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8. - pytorch#130836 See the PR description of pytorch#130836 for more details. `sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically: - Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations) > BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([pytorch#25614](sympy/sympy#25614) by [@smichr](https://github.com/smichr)) `sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of pytorch#130689. - pytorch#130689 Pull Request resolved: pytorch#130895 Approved by: https://github.com/ezyang

Update

bf5b562

[ghstack-poisoned]

XuehaiPan requested a review from a team as a code owner July 16, 2024 13:45

pytorch-bot Bot added the topic: not user facing topic category label Jul 16, 2024

pytorchbot added the open source label Jul 16, 2024

XuehaiPan requested review from ezyang, guangyey and lezcano July 16, 2024 13:49

XuehaiPan added oncall: releng In support of CI and Release Engineering dynamo-symbolic-analysis labels Jul 16, 2024

XuehaiPan added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 16, 2024

XuehaiPan requested a review from albanD July 16, 2024 16:39

justinchuby mentioned this pull request Jul 16, 2024

[ONNX] Remove beartype usage #130484

Closed

XuehaiPan added ciflow/mps Run MPS tests (subset of trunk) ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/xpu Run XPU CI tasks labels Jul 16, 2024

XuehaiPan removed the ciflow/xpu Run XPU CI tasks label Jul 17, 2024

XuehaiPan mentioned this pull request Jul 17, 2024

Pin sympy >= 1.13.0 #130895

Closed

XuehaiPan closed this Jul 17, 2024

francograndegmailcom pushed a commit to francograndegmailcom/pytorch-pytorch that referenced this pull request Jul 23, 2024

Pin sympy < 1.13.0a0

014a041

ghstack-source-id: 864a00c Pull Request resolved: pytorch/pytorch#130836

github-actions Bot deleted the gh/XuehaiPan/125/head branch August 17, 2024 02:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pin `sympy < 1.13.0a0`#130836

Pin `sympy < 1.13.0a0`#130836
XuehaiPan wants to merge 1 commit intogh/XuehaiPan/125/basefrom
gh/XuehaiPan/125/head

XuehaiPan commented Jul 16, 2024 •

edited

Loading

Uh oh!

pytorch-bot Bot commented Jul 16, 2024 •

edited

Loading

Uh oh!

Skylion007 commented Jul 16, 2024

Uh oh!

XuehaiPan commented Jul 16, 2024

Uh oh!

XuehaiPan commented Jul 16, 2024

Uh oh!

albanD commented Jul 16, 2024

Uh oh!

ezyang commented Jul 17, 2024

Uh oh!

XuehaiPan commented Jul 17, 2024

Uh oh!

XuehaiPan commented Jul 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

XuehaiPan commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130836

❌ 4 New Failures, 1 Cancelled Job, 2 Unrelated Failures

Uh oh!

Skylion007 commented Jul 16, 2024

Uh oh!

XuehaiPan commented Jul 16, 2024

Uh oh!

XuehaiPan commented Jul 16, 2024

Uh oh!

albanD commented Jul 16, 2024

Uh oh!

ezyang commented Jul 17, 2024

Uh oh!

XuehaiPan commented Jul 17, 2024

Uh oh!

XuehaiPan commented Jul 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

XuehaiPan commented Jul 16, 2024 •

edited

Loading

pytorch-bot Bot commented Jul 16, 2024 •

edited

Loading