[Inductor] [CI] [CUDA] Skip the failed models and tests the better way#127150
Closed
nWEIdia wants to merge 9 commits intopytorch:mainfrom
Closed
[Inductor] [CI] [CUDA] Skip the failed models and tests the better way#127150nWEIdia wants to merge 9 commits intopytorch:mainfrom
nWEIdia wants to merge 9 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127150
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (1 Unrelated Failure)As of commit 6fd0056 with merge base f4cbcff ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
added a commit
to huydhn/pytorch
that referenced
this pull request
May 25, 2024
Contributor
huydhn
approved these changes
May 25, 2024
huydhn
reviewed
May 25, 2024
benchmarks/dynamo/ci_expected_accuracy/dynamic_inductor_timm_training.csv
Outdated
Show resolved
Hide resolved
Collaborator
Author
nWEIdia
commented
May 25, 2024
Add back shards and disable models by setting the accuracy to "fail Relax inductor perf smoke speedup from 4.9 to 4.7 for cuda 12.4 only Duplicate cu121 csv reference to cu124 to workaround pytorch#126692 Change back to pass after fixing pytorch#126692
4c5efe9 to
4b723f8
Compare
eqy
approved these changes
May 29, 2024
This reverts commit 14a1867.
Just do not import torch under torch/ directory
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
Jun 5, 2024
pytorch#127150) Address subtasks in pytorch#126692 After enabling the disabled shards, the following two models regressed (for cu124 configuration): dynamic_inductor_timm_training.csv cspdarknet53,pass,7 (expected) | cspdarknet53,fail_accuracy,7 (actual) eca_botnext26ts_256,pass,7 (expected) | eca_botnext26ts_256,fail_accuracy,7 (actual) Pull Request resolved: pytorch#127150 Approved by: https://github.com/huydhn, https://github.com/eqy, https://github.com/atalman
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 25, 2024
…ilar enough to cu121 (#128423) Pre-requisite: close #126692 first. This PR also gives a current read on cu121 and cu124 parity. Essentially reverting #127150 Pull Request resolved: #128423 Approved by: https://github.com/atalman, https://github.com/eqy
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 27, 2024
…ilar enough to cu121 (#128423) Pre-requisite: close #126692 first. This PR also gives a current read on cu121 and cu124 parity. Essentially reverting #127150 Pull Request resolved: #128423 Approved by: https://github.com/atalman, https://github.com/eqy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address subtasks in #126692
After enabling the disabled shards, the following two models regressed (for cu124 configuration):
dynamic_inductor_timm_training.csv
cspdarknet53,pass,7 (expected) | cspdarknet53,fail_accuracy,7 (actual)
eca_botnext26ts_256,pass,7 (expected) | eca_botnext26ts_256,fail_accuracy,7 (actual)
cc @albanD @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @atalman @malfet @ptrblck @eqy @tinglvv @Aidyn-A