Skip to content

Fix typo in inductor workflow for CUDA 12.4 jobs#127121

Closed
huydhn wants to merge 3 commits intopytorch:mainfrom
huydhn:fix-typo-cuda12.4-build
Closed

Fix typo in inductor workflow for CUDA 12.4 jobs#127121
huydhn wants to merge 3 commits intopytorch:mainfrom
huydhn:fix-typo-cuda12.4-build

Conversation

@huydhn
Copy link
Copy Markdown
Contributor

@huydhn huydhn commented May 24, 2024

Discovered by @clee2000. The change was introduced in #121956

@huydhn huydhn requested a review from clee2000 May 24, 2024 19:20
@huydhn huydhn requested a review from a team as a code owner May 24, 2024 19:20
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 24, 2024
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented May 24, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127121

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f94f513 with merge base 9117779 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 25, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 25, 2024

Merge failed

Reason: Comment with id 2130674642 not found

Details for Dev Infra team Raised by workflow job

@huydhn
Copy link
Copy Markdown
Contributor Author

huydhn commented May 25, 2024

@pytorchbot merge -f 'CI-only fix, the workflow looks correct now https://github.com/pytorch/pytorch/actions/runs/9228931556/job/25395239009, merging this to avoid conflict with #127150'

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 25, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn huydhn mentioned this pull request May 25, 2024
Closed
titaiwangms pushed a commit to titaiwangms/pytorch that referenced this pull request May 28, 2024
@huydhn @titaiwangms
Fix typo in inductor workflow for CUDA 12.4 jobs (pytorch#127121)
9819893 
Discovered by @clee2000.  The change was introduced in pytorch#121956
Pull Request resolved: pytorch#127121
Approved by: https://github.com/clee2000, https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

+1 more reviewer

@clee2000 clee2000 clee2000 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/inductor Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huydhn @pytorchmergebot @Skylion007 @clee2000