Skip to content

[inductor] Relax type annotations for statically_known_*#126655

Closed
jansel wants to merge 2 commits intogh/jansel/338/basefrom
gh/jansel/338/head
Closed

[inductor] Relax type annotations for statically_known_*#126655
jansel wants to merge 2 commits intogh/jansel/338/basefrom
gh/jansel/338/head

Conversation

@jansel
Copy link
Contributor

@jansel jansel commented May 19, 2024 •
edited
Loading

@jansel
Update
d5046a6 
[ghstack-poisoned]
@jansel jansel mentioned this pull request May 19, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented May 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126655

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8df6e0c with merge base 6550386 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jansel jansel mentioned this pull request May 19, 2024
Closed
@jansel jansel mentioned this pull request May 19, 2024
Closed
@jansel
Update
8df6e0c 
[ghstack-poisoned]
@jansel jansel requested a review from shunting314 May 21, 2024 04:10
shunting314
shunting314 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@shunting314 shunting314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just curious why we don't loose the type annotation for the left argument as well?

@jansel
Copy link
Contributor Author

jansel commented May 21, 2024

Looks good. Just curious why we don't loose the type annotation for the left argument as well?

We could, but calling it on (int, int) doesn't make any sense.

@jansel
Copy link
Contributor Author

jansel commented May 21, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 21, 2024
@jansel jansel added topic: not user facing topic category and removed ciflow/trunk Trigger trunk jobs on your pull request labels May 21, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 21, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@shunting314
Copy link
Contributor

shunting314 commented May 21, 2024 •
edited
Loading

We could, but calling it on (int, int) doesn't make any sense.

But (int, sympy.Expr) is legit? lol

pytorchmergebot pushed a commit that referenced this pull request May 22, 2024
@jansel @pytorchmergebot
[halide-backend] Add HalideCodeCache (#126416)
b516de8 
Pull Request resolved: #126416
Approved by: https://github.com/shunting314
ghstack dependencies: #126631, #126655
@github-actions github-actions bot deleted the gh/jansel/338/head branch June 21, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@shunting314 shunting314 shunting314 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jansel @pytorchmergebot @shunting314 @Skylion007