Skip to content

[halide-backend] Add HalideCodeCache#126416

Closed
jansel wants to merge 14 commits intogh/jansel/334/basefrom
gh/jansel/334/head
Closed

[halide-backend] Add HalideCodeCache#126416
jansel wants to merge 14 commits intogh/jansel/334/basefrom
gh/jansel/334/head

Conversation

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented May 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126416

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit ac396ff with merge base 6550386 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
jansel added 5 commits May 16, 2024 20:28
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@jansel jansel marked this pull request as ready for review May 17, 2024 16:32
[ghstack-poisoned]
jansel added 2 commits May 17, 2024 14:50
[ghstack-poisoned]
[ghstack-poisoned]
jansel added 2 commits May 19, 2024 13:25
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@jansel jansel requested a review from shunting314 May 21, 2024 04:11
"""
),
)
a = torch.randn(1024)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a general question when looking at the test: The test is running on CPU, do we plan to use halide for GPU as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in a future PR.



try:
import halide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we install halide as a dependency for any of the ci jobs? I dont think this will run at all currently right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, do you know any easy way to do this? There aren't pypi packages for it, so it will need an apt-get install or build from source.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure exactly - maybe .ci/docker/common/install_base.sh - there are apt-get calls there

),
],
target="host",
scheduler="Mullapudi2016",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious - why this scheduler the others ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a placeholder while I focus on functionality.

[ghstack-poisoned]
@jansel
Copy link
Contributor Author

jansel commented May 22, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 22, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/jansel/334/head branch June 22, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants