[pt1][tensor] Remove New with Allocator Registry#12111
Closed
jerryzh168 wants to merge 44 commits intomasterfrom
Closed
[pt1][tensor] Remove New with Allocator Registry#12111jerryzh168 wants to merge 44 commits intomasterfrom
jerryzh168 wants to merge 44 commits intomasterfrom
Conversation
Differential Revision: D9779821 Differential Version: 57806436
Differential Revision: D9779821 Differential Version: 58713403
Differential Revision: D9779821 Differential Version: 58748651
Differential Revision: D9889990 Differential Version: 58748485
Differential Revision: D9889990 Differential Version: 58751934
Differential Revision: D10033396 Differential Version: 58815881
Differential Revision: D9889990 Differential Version: 58856304
Differential Revision: D10033396 Differential Version: 58856963
Differential Revision: D9889990 Differential Version: 58875107
Differential Revision: D10022853 Differential Version: 58947676
This was referenced Sep 26, 2018
Differential Revision: D10033396 Differential Version: 59085834
Differential Revision: D9889990 Differential Version: 59110247
Differential Revision: D10033396 Differential Version: 59227528
Differential Revision: D9889990 Differential Version: 59619253
This was referenced Oct 3, 2018
Differential Revision: D10022853 Differential Version: 59663517
Differential Revision: D9889990 Differential Version: 59666455
Differential Revision: D10001033 Differential Version: 59666456
Differential Revision: D10022853 Differential Version: 59730149
Differential Revision: D10022853 Differential Version: 59769948
Differential Revision: D10022853 Differential Version: 59783324
Contributor
Author
|
@pytorchbot retest this please |
ezyang
reviewed
Oct 5, 2018
aten/src/ATen/core/Allocator.h
Outdated
| // using AllocatorArray = std::array< | ||
| // std::unique_ptr<at::Allocator>, | ||
| // static_cast<int>(at::DeviceType::COMPILE_TIME_MAX_DEVICE_TYPES)>; | ||
| /** Set the allocator for DeviceType `t` and takes ownership of the allocator |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Oct 5, 2018
ezyang
requested changes
Oct 5, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
Wondering about ownership of these allocators.
Differential Revision: D10022853 Differential Version: 59886111
Differential Revision: D10022853 Differential Version: 59892819
ezyang
reviewed
Oct 8, 2018
Contributor
Author
|
@ezyang can you approve on phabricator as well? |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 9, 2018
Summary: Pull Request resolved: pytorch/pytorch#12111 Setup allocator registry keyed by at::DeviceType, and remove New from StaticContext. Reviewed By: ezyang Differential Revision: D10022853 fbshipit-source-id: 3e88a181fe5df24f33f49b88be1f75284a185588
gchanan
pushed a commit
to gchanan/pytorch
that referenced
this pull request
Oct 10, 2018
Summary: Pull Request resolved: pytorch#12111 Setup allocator registry keyed by at::DeviceType, and remove New from StaticContext. Reviewed By: ezyang Differential Revision: D10022853 fbshipit-source-id: 3e88a181fe5df24f33f49b88be1f75284a185588
gchanan
pushed a commit
to gchanan/pytorch
that referenced
this pull request
Oct 10, 2018
Summary: Pull Request resolved: pytorch#12111 Setup allocator registry keyed by at::DeviceType, and remove New from StaticContext. Reviewed By: ezyang Differential Revision: D10022853 fbshipit-source-id: 3e88a181fe5df24f33f49b88be1f75284a185588
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #12111 [pt1][tensor] Remove New with Allocator Registry 💛
:white_circle: #12304 [pt1][tensor] Remove ExtractDeviceOption from StaticContext 💚
:white_circle: #12305 [pt1][tensor] Remove StaticContext 💚
:white_circle: #12407 [pt1][tensor] caffe2::empty for Resize+mutable_data refactor 💛
Setup allocator registry keyed by at::DeviceType, and remove New from StaticContext.
Differential Revision: D10022853