[pt1][tensor] Remove ExtractDeviceOption from StaticContext#12304
Closed
jerryzh168 wants to merge 54 commits intomasterfrom
Closed
[pt1][tensor] Remove ExtractDeviceOption from StaticContext#12304jerryzh168 wants to merge 54 commits intomasterfrom
jerryzh168 wants to merge 54 commits intomasterfrom
Conversation
Differential Revision: D9779821 Differential Version: 57806436
Differential Revision: D9779821 Differential Version: 58713403
Differential Revision: D9779821 Differential Version: 58748651
Differential Revision: D9889990 Differential Version: 58748485
Differential Revision: D9889990 Differential Version: 58751934
Differential Revision: D10033396 Differential Version: 58815881
Differential Revision: D9889990 Differential Version: 58856304
Differential Revision: D10033396 Differential Version: 58856963
Differential Revision: D9889990 Differential Version: 58875107
Differential Revision: D10022853 Differential Version: 58947676
Differential Revision: D10033396 Differential Version: 59085834
Differential Revision: D9889990 Differential Version: 59110247
Differential Revision: D10033396 Differential Version: 59227528
Differential Revision: D9889990 Differential Version: 59619253
Differential Revision: D9889990 Differential Version: 59621759
Differential Revision: D10001033 Differential Version: 59624116
Differential Revision: D9889990 Differential Version: 59625764
Differential Revision: D10022853 Differential Version: 59663517
Differential Revision: D9889990 Differential Version: 59666455
Differential Revision: D10001033 Differential Version: 59666456
Differential Revision: D10022853 Differential Version: 59730149
Differential Revision: D10022853 Differential Version: 59769948
Differential Revision: D10022853 Differential Version: 59783324
Differential Revision: D10022853 Differential Version: 59886111
Differential Revision: D10022853 Differential Version: 59892819
Differential Revision: D10069839 Differential Version: 60055449
Differential Revision: D10022853 Differential Version: 60136698
Differential Revision: D10069839 Differential Version: 60144811
Differential Revision: D10069839 Differential Version: 60192180
Contributor
Author
|
@pytorchbot retest this please |
Differential Revision: D10069839 Differential Version: 60272376
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 10, 2018
Summary: Pull Request resolved: pytorch/pytorch#12304 - make ExtractDeviceOption to be a free function. - Add a Strorage(at::Device) constructor in order to preserve the device_id. Reviewed By: dzhulgakov Differential Revision: D10069839 fbshipit-source-id: a5f3994a39bdf1b7503b39bb42c228e438b52bfa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #12304 [pt1][tensor] Remove ExtractDeviceOption from StaticContext 💚
:white_circle: #12305 [pt1][tensor] Remove StaticContext 💚
Differential Revision: D10069839