Move TensorImpl::ShrinkTo to caffe2::Tensor#12090
Closed
ezyang wants to merge 2 commits intoexport-D10050859from
Closed
Move TensorImpl::ShrinkTo to caffe2::Tensor#12090ezyang wants to merge 2 commits intoexport-D10050859from
ezyang wants to merge 2 commits intoexport-D10050859from
Conversation
Differential Revision: D10050905 Differential Version: 58924266
This was referenced Sep 26, 2018
Closed
Differential Revision: D10050905 Differential Version: 58925033
This was referenced Sep 26, 2018
jerryzh168
approved these changes
Sep 27, 2018
Contributor
jerryzh168
left a comment
There was a problem hiding this comment.
Approved via ghapprove -s D10051424
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 28, 2018
Summary: Pull Request resolved: pytorch/pytorch#12090 This is a slight pessimization because we need to do a full recompute of is_contiguous(), even though a modification of dim-0 is guaranteed to preserve contiguity. Reviewed By: jerryzh168 Differential Revision: D10050905 fbshipit-source-id: b99233e21c9f4275b0db6e76740462e5430ce152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #11970 Make ATen-core and caffe2 mutually recursive / merge template data() 💛
:white_circle: #11971 Merge TensorImpl. 💛
:white_circle: #11972 Merge UndefinedTensorImpl. 💚
:white_circle: #12087 Rename TensorImpl::GetDeviceType to device_type, and properly test if is_variable 💛
:white_circle: #12089 Move ExtendTo to caffe2::Tensor from TensorImpl 💛
:black_circle: #12090 Move TensorImpl::ShrinkTo to caffe2::Tensor 💛
:white_circle: #12091 Move TensorImpl::ResizeLike to caffe2::Tensor 💛
:white_circle: #12092 Fix bug where Reshape() trashes strides. 💛
:white_circle: #12094 Move TensorImpl::Reshape(vector) to caffe2::Tensor 💛
:white_circle: #12095 Move TensorImpl::DebugString() to caffe2::Tensor 💛
:white_circle: #12096 Move TensorImpl::ShareExternalPointer helper overloads to caffe2::Tensor 💛
:white_circle: #12097 Implement caffe2::Tensor::raw_data() in terms of data() 💛
:white_circle: #12098 Move TensorImpl ndim, size, itemsize and nbytes to caffe2::Tensor 💛
:white_circle: #12099 Move TensorImpl size_from_dim, size_to_dim, size_between_dim, canonical_axis_index to caffe2::Tensor 💛
:white_circle: #12100 Move TensorImpl IsType, meta, dim32, dim, ExtractDeviceOption to caffe2::Tensor 💛
This is a slight pessimization because we need to do a
full recompute of is_contiguous(), even though a modification
of dim-0 is guaranteed to preserve contiguity.
Differential Revision: D10050905