Make ATen-core and caffe2 mutually recursive / merge template data<T>()#11970
Closed
Make ATen-core and caffe2 mutually recursive / merge template data<T>()#11970
Conversation
Differential Revision: D9967509 Differential Version: 58616441
This was referenced Sep 22, 2018
Closed
Closed
Closed
Differential Revision: D9967509 Differential Version: 58638320
Differential Revision: D9967509 Differential Version: 58689896
Differential Revision: D9967509 Differential Version: 58739232
Differential Revision: D9967509 Differential Version: 58745778
Differential Revision: D9967509 Differential Version: 58821972
Differential Revision: D9967509 Differential Version: 58825273
gchanan
reviewed
Sep 26, 2018
| inline T * data() const { | ||
| CAFFE_ENFORCE_WITH_CALLER( | ||
| storage_.data() || numel_ == 0, | ||
| "The tensor is of non-zero shape, but its data is not allocated yet. " |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Differential Revision: D9967509 Differential Version: 58923258
This was referenced Sep 26, 2018
jerryzh168
approved these changes
Sep 27, 2018
Differential Revision: D9967509 Differential Version: 59091387
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 28, 2018
…() (#11970) Summary: Pull Request resolved: pytorch/pytorch#11970 Adds an ATen-core-headers target, which caffe2_cpu_internal depends on, and makes ATen-core depend on caffe2_headers. If you link against ATen-core, you must ALSO link against caffe2_cpu_internal; if you link against caffe2_cpu_internal, you must ALSO link against ATen-core, otherwise you'll have undefined symbols. Then, we merge template data<T>() method with Caffe2 implementation, demonstrating that includes to Caffe2 (core) from ATen/core are working Reviewed By: jerryzh168 Differential Revision: D9967509 fbshipit-source-id: 3d220c38b2c3c646f8ff2884fdcc889fa9276c7a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11970 Make ATen-core and caffe2 mutually recursive / merge template data() 💚
:white_circle: #11971 Merge TensorImpl. 💚
Adds an ATen-core-headers target, which caffe2_cpu_internal depends
on, and makes ATen-core depend on caffe2_headers. If you link against
ATen-core, you must ALSO link against caffe2_cpu_internal; if you
link against caffe2_cpu_internal, you must ALSO link against ATen-core,
otherwise you'll have undefined symbols.
Then, we merge template data() method with Caffe2 implementation,
demonstrating that includes to Caffe2 (core) from ATen/core are working
Differential Revision: D9967509