[pt1][tensor] New in StaticContext returns at::DataPtr#12029
Closed
jerryzh168 wants to merge 27 commits intomasterfrom
Closed
[pt1][tensor] New in StaticContext returns at::DataPtr#12029jerryzh168 wants to merge 27 commits intomasterfrom
jerryzh168 wants to merge 27 commits intomasterfrom
Conversation
Differential Revision: D9779821 Differential Version: 57806436
Differential Revision: D9779821 Differential Version: 58713403
Differential Revision: D9779821 Differential Version: 58748651
Differential Revision: D9889990 Differential Version: 58748485
Differential Revision: D9889990 Differential Version: 58751934
Differential Revision: D10033396 Differential Version: 58815881
Differential Revision: D9889990 Differential Version: 58856304
Differential Revision: D10033396 Differential Version: 58856963
Differential Revision: D9889990 Differential Version: 58875107
This was referenced Sep 26, 2018
ezyang
reviewed
Sep 27, 2018
ezyang
reviewed
Sep 27, 2018
caffe2/core/allocator.h
Outdated
| memset(data, 0, nbytes); | ||
| } | ||
| return {data, Delete}; | ||
| LOG(INFO) << "allocated data: " << data; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Sep 27, 2018
caffe2/core/allocator.h
Outdated
| } | ||
| #else | ||
| static void Delete(void* data) { | ||
| LOG(INFO) << "destructed " << data; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Sep 27, 2018
caffe2/core/context_gpu.h
Outdated
| auto ptr_and_deleter = baseAllocator_.New(nbytes); | ||
| data = ptr_and_deleter.first; | ||
| auto data_ptr = baseAllocator_.allocate(nbytes); | ||
| data = data_ptr.move_context().release(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Sep 27, 2018
ezyang
reviewed
Sep 27, 2018
caffe2/core/hip/context_hip.h
Outdated
| auto ptr_and_deleter = baseAllocator_.New(nbytes); | ||
| data = ptr_and_deleter.first; | ||
| auto data_ptr = baseAllocator_.allocate(nbytes); | ||
| data = data_ptr.move_context().release(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Sep 27, 2018
caffe2/core/hip/miopen_wrapper.h
Outdated
| auto data_and_deleter = HIPContext::New(nbytes); | ||
| data_ = {data_and_deleter.first, data_and_deleter.second}; | ||
| auto data_ptr = HIPContext::New(nbytes); | ||
| data_ = {data_ptr.move_context().release(), data_ptr.get_deleter()}; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Sep 27, 2018
caffe2/core/qtensor.h
Outdated
| static_cast<unsigned char*>(ptr_and_deleter.first), | ||
| ptr_and_deleter.second); | ||
| static_cast<unsigned char*>(data_ptr.move_context().release()), | ||
| data_ptr.get_deleter()); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Sep 27, 2018
caffe2/core/tensor_impl.h
Outdated
| deleter(local_ptr); | ||
| }, | ||
| storage_.set_data_ptr(PlacementDeleteContext::makeDataPtr( | ||
| std::move(data_ptr.move_context()), |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Differential Revision: D9889990 Differential Version: 59110247
Differential Revision: D10033396 Differential Version: 59227528
ezyang
reviewed
Oct 3, 2018
aten/src/ATen/core/TensorImpl.h
Outdated
| ptr_and_deleter.second, | ||
| at::Device(storage_.device_type()))); | ||
| auto data_ptr = GetStaticContext()->New(numel_ * storage_.itemsize()); | ||
| storage_.set_data_ptr(std::move(data_ptr)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Oct 3, 2018
Differential Revision: D9889990 Differential Version: 59619253
Differential Revision: D9889990 Differential Version: 59621759
Differential Revision: D9889990 Differential Version: 59625764
Differential Revision: D9889990 Differential Version: 59628377
This was referenced Oct 3, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Oct 4, 2018
Summary: Pull Request resolved: pytorch/pytorch#12029 In order to remove New() function in StaticContext(to remove StaticContext) and converge to the Allocator design, we'll first change the return type of New to at::DataPtr. Reviewed By: ezyang Differential Revision: D9889990 fbshipit-source-id: 3257c763530b987025f428741bdd2e089d11bad4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #12029 [pt1][tensor] New in StaticContext returns at::DataPtr 💛
:white_circle: #12105 [pt1][tensor] Split Allocator 💛
:white_circle: #12111 [pt1][tensor] Remove New with Allocator Registry 💛
In order to remove New() function in StaticContext(to remove StaticContext) and converge to the Allocator design, we'll first change the return type of New to at::DataPtr.
Differential Revision: D9889990